#43761 closed defect (bug) (fixed)
CS: Fix violations for wp-admin/install-helper.php
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Upgrade/Install | Keywords: | has-patch commit |
Focuses: | coding-standards | Cc: |
Description
Working on this currently, during WordCamp London contributor day.
Attachments (1)
Change History (11)
This ticket was mentioned in PR #3478 on WordPress/wordpress-develop by @costdev.
2 years ago
#3
#4
@
2 years ago
- Keywords dev-feedback added
PR 3478 refreshes 43761-fix-coding-standards.patch against trunk
with some changes to update sniff names and change the last batch to a temporarily disable/re-enable.
Pinging @jrf for feedback on whether these changes are appropriate.
#6
@
2 years ago
- Keywords commit added; dev-feedback removed
- Milestone changed from Awaiting Review to 6.2
I have updated the PR with changes after feedback from @jrf. Thanks Juliette!
Adding for commit
consideration.
@SergeyBiryukov commented on PR #3478:
2 years ago
#8
Thanks for the PR! This looks good to me, I just had a question about one of the changes.
@SergeyBiryukov commented on PR #3478:
2 years ago
#10
Thanks for the PR! Merged in r54858.
Note: See
TracTickets for help on using
tickets.
Refreshes 43761-fix-coding-standards.patch against
trunk
with some minor updates.---
This adds inline comments instructing PHPCS to ignore some lines for database queries and property naming in
wp-admin/install-helper.php
.An explanation is provided with each instruction.
The sniffs in question are: