WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#43765 closed defect (bug) (fixed)

CS Violations: wp-includes/version.php

Reported by: sephsekla's profile sephsekla Owned by: pento's profile pento
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: coding-standards Cc:

Description (last modified by ocean90)


Attachments (5)

43765.patch​ (325 bytes) - added by sephsekla 7 years ago.
43765.2.patch​ (386 bytes) - added by sephsekla 7 years ago.
Updated patch as per @ocean90's comment
43765.3.patch​ (401 bytes) - added by bruceallen 6 years ago.
2nd update of patch as per request
43765.diff​ (389 bytes) - added by bruceallen 6 years ago.
43765.2.diff​ (391 bytes) - added by bruceallen 6 years ago.

Download all attachments as: .zip

Change History (14)

@sephsekla
7 years ago

#1 @ocean90
7 years ago

  • Focuses coding-standards added
  • Keywords needs-refresh added

Hello @sephsekla, welcome to WordPress Trac!

Thanks for your patch. The @package tag should be part of a file header and not the doc of global variable. Would you like to add a new patch that adds a file header to the file?

@sephsekla
7 years ago

Updated patch as per @ocean90's comment

#2 @ocean90
7 years ago

  • Description modified (diff)
  • Keywords needs-refresh removed
  • Milestone changed from Awaiting Review to 5.0

Thanks!

Last edited 7 years ago by ocean90 (previous) (diff)

#3 @ocean90
7 years ago

  • Description modified (diff)

#4 @netweb
7 years ago

  • Keywords needs-refresh added; has-patch removed

Thanks also @sephsekla, if I may ask you to refresh the patch again please and add @since 1.1.0 per:

​https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#6-file-headers

FYI: For reference, version.php was added in [803] as part of WordPress 1.1

#5 @ocean90
7 years ago

  • Keywords has-patch added

@bruceallen
6 years ago

2nd update of patch as per request

#6 @bruceallen
6 years ago

Working on version 4 of patch now.

#7 @pento
6 years ago

  • Keywords needs-refresh removed
  • Owner set to pento
  • Status changed from new to assigned

@bruceallen
6 years ago

@bruceallen
6 years ago

#8 @pento
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43662:

Docs: Add a file header comment to version.php.

Props sephsekla, bruceallen.
Fixes #43765.

#9 @SergeyBiryukov
6 years ago

  • Milestone changed from 5.0 to 5.1

Switching milestone due to the focus on the new editor (Gutenberg) for WordPress 5.0.

Note: See TracTickets for help on using tickets.