WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 8 weeks ago

#43773 new defect (bug)

TinyMCE: some keyboard shortcuts are not displayed in the tooltips

Reported by: afercia Owned by:
Milestone: 4.9.7 Priority: normal
Severity: normal Version: 4.7
Component: Editor Keywords: has-patch has-screenshots dev-feedback
Focuses: Cc:

Description

In [38897] some TinyMCE keyboard shortcuts were made more discoverable by adding them to the buttons tooltips. However, some of them aren't displayed correctly.

When the user language is set to English:

  • Bulleted list: no shortcut displayed
  • Numbered list: OK
  • Insert/edit link: no shortcut displayed

https://cldup.com/ff6XOFcLnU.png

When the user language is set to any other language:

  • none of them works

https://cldup.com/y25_B-ROXt.png

Seems to me the Insert/edit link case is simpler, while the lists are a bit more tricky because they are actually a TinyMCE plugin.

Attachments (1)

43773.diff (2.4 KB) - added by afercia 2 months ago.

Download all attachments as: .zip

Change History (6)

@afercia
2 months ago

#1 @afercia
2 months ago

  • Keywords has-patch has-screenshots added; needs-patch removed

43773.diff works but is, in a way, a hack. To my understanding, ideally the tooltip property should be added in the lists buttons object in the lists plugin, see src/wp-includes/js/tinymce/plugins/lists/plugin.js so a fix upstream would probably be the best option. /Cc @azaozz @iseulde

#2 @desrosj
2 months ago

  • Keywords dev-feedback added

I was able to reproduce the issue described and 43773.diff does fix the problem.

@azaozz or @iseulde, do you have any thoughts on this for 4.9.6?

This ticket was mentioned in Slack in #core by desrosj. View the logs.


2 months ago

This ticket was mentioned in Slack in #core by desrosj. View the logs.


8 weeks ago

#5 @desrosj
8 weeks ago

  • Milestone changed from 4.9.6 to 4.9.7

Waiting for a 2nd opinion. Punting.

Note: See TracTickets for help on using tickets.