TinyMCE: some keyboard shortcuts are not displayed in the tooltips

[afercia]

In [38897] some TinyMCE keyboard shortcuts were made more discoverable by adding them to the buttons tooltips. However, some of them aren't displayed correctly.

When the user language is set to English:

• Bulleted list: no shortcut displayed
• Numbered list: OK
• Insert/edit link: no shortcut displayed

When the user language is set to any other language:

• none of them works

Seems to me the Insert/edit link case is simpler, while the lists are a bit more tricky because they are actually a TinyMCE plugin.

[afercia]

43773.diff​ works but is, in a way, a hack. To my understanding, ideally the tooltip property should be added in the lists buttons object in the lists plugin, see src/wp-includes/js/tinymce/plugins/lists/plugin.js so a fix upstream would probably be the best option. /Cc @azaozz @iseulde

[desrosj]

I was able to reproduce the issue described and 43773.diff​ does fix the problem.

@azaozz or @iseulde, do you have any thoughts on this for 4.9.6?

[desrosj]

Waiting for a 2nd opinion. Punting.

[ocean90]

4.9.7 has been released, moving to next milestone.

[pento]

4.9.8 is in RC.

This needs feedback from @iseulde or @azaozz to move forward, so I'm moving it to Awaiting Review.

[afercia]

I'm not sure "Awaiting Review" is the proper milestone. "Awaiting Review" is meant for fresh tickets that haven't been reviewed yet. Tickets marked as such go in the awaiting review report. This ticket has already been initially reviewed, marking it again with "Awaiting Review" will pollute the related report and increase the work load for the component maintainers and bug gardeners. In such cases, I'd say a more proper milestone is the next milestone (if any) or "Future Release".

Workflows:
​https://make.wordpress.org/core/handbook/testing/bug-gardening/
​https://make.wordpress.org/core/handbook/contribute/trac/

[desrosj]

I did some testing on this and it seem that this was solved in another ticket as I can no longer reproduce. To test, I followed the steps above using both English and German and the Classic Editor plugin, but all shortcuts correctly displayed in the tooltips.

If anyone is able to reproduce this, feel free to reopen and provide more details to reproduce. I am marking this as low priority because it affects only the Classic Editor. I did some searching but was unable to find another ticket addressing this. If someone knows where this was solved, please just drop a comment to connect the dots.

[desrosj]

One more scenario that I tested and forgot to mention: using the Classic block in the block editor with English and German. Both worked as expected.

[afercia]

Right. Fixed in [45066] / #35710.