WordPress.org

Make WordPress Core

Opened 18 months ago

Last modified 4 months ago

#43773 new defect (bug)

TinyMCE: some keyboard shortcuts are not displayed in the tooltips

Reported by: afercia Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.7
Component: Editor Keywords: has-patch has-screenshots dev-feedback
Focuses: Cc:
PR Number:

Description

In [38897] some TinyMCE keyboard shortcuts were made more discoverable by adding them to the buttons tooltips. However, some of them aren't displayed correctly.

When the user language is set to English:

  • Bulleted list: no shortcut displayed
  • Numbered list: OK
  • Insert/edit link: no shortcut displayed

https://cldup.com/ff6XOFcLnU.png

When the user language is set to any other language:

  • none of them works

https://cldup.com/y25_B-ROXt.png

Seems to me the Insert/edit link case is simpler, while the lists are a bit more tricky because they are actually a TinyMCE plugin.

Attachments (1)

43773.diff (2.4 KB) - added by afercia 18 months ago.

Download all attachments as: .zip

Change History (12)

@afercia
18 months ago

#1 @afercia
18 months ago

  • Keywords has-patch has-screenshots added; needs-patch removed

43773.diff works but is, in a way, a hack. To my understanding, ideally the tooltip property should be added in the lists buttons object in the lists plugin, see src/wp-includes/js/tinymce/plugins/lists/plugin.js so a fix upstream would probably be the best option. /Cc @azaozz @iseulde

#2 @desrosj
18 months ago

  • Keywords dev-feedback added

I was able to reproduce the issue described and 43773.diff does fix the problem.

@azaozz or @iseulde, do you have any thoughts on this for 4.9.6?

This ticket was mentioned in Slack in #core by desrosj. View the logs.


18 months ago

This ticket was mentioned in Slack in #core by desrosj. View the logs.


18 months ago

#5 @desrosj
18 months ago

  • Milestone changed from 4.9.6 to 4.9.7

Waiting for a 2nd opinion. Punting.

#6 @ocean90
16 months ago

  • Milestone changed from 4.9.7 to 4.9.8

4.9.7 has been released, moving to next milestone.

This ticket was mentioned in Slack in #core by pbiron. View the logs.


15 months ago

#8 @pento
15 months ago

  • Milestone changed from 4.9.8 to Awaiting Review

4.9.8 is in RC.

This needs feedback from @iseulde or @azaozz to move forward, so I'm moving it to Awaiting Review.

#9 @afercia
15 months ago

  • Milestone changed from Awaiting Review to 4.9.9

I'm not sure "Awaiting Review" is the proper milestone. "Awaiting Review" is meant for fresh tickets that haven't been reviewed yet. Tickets marked as such go in the awaiting review report. This ticket has already been initially reviewed, marking it again with "Awaiting Review" will pollute the related report and increase the work load for the component maintainers and bug gardeners. In such cases, I'd say a more proper milestone is the next milestone (if any) or "Future Release".

Workflows:
https://make.wordpress.org/core/handbook/testing/bug-gardening/
https://make.wordpress.org/core/handbook/contribute/trac/

#10 @pento
12 months ago

  • Milestone changed from 4.9.9 to Future Release

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


9 months ago

Note: See TracTickets for help on using tickets.