Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#43776 closed defect (bug) (fixed)

CS: minor adjustment to the PHPCS ruleset

Reported by:	jrf	Owned by:	johnbillion
Priority:	normal	Milestone:	5.1
Component:	Build/Test Tools	Version:	5.1
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:	coding-standards

Description

The reference to the WordPress.Variables.GlobalVariables sniff needs to be removed from the ruleset.

This sniff is not included in the WordPress-Core ruleset as Core writing to Core global variables is fine (of course).

Passing the custom properties which are needed by themes and plugins, activates the sniff needlessly.

Related: #43764 - see https://core.trac.wordpress.org/ticket/43764#comment:1

Attachments (1)

43776-wpcs-ruleset-adjustment.patch (1.4 KB ) - added by jrf 8 years ago.

Download all attachments as: .zip

Change History (4)

@jrf
8 years ago

Attachment 43776-wpcs-ruleset-adjustment.patch added

#1 @netweb
8 years ago

Keywords commit added
Milestone Awaiting Review → 5.0

👍

#2 @johnbillion
8 years ago

Owner set to johnbillion
Resolution → fixed
Status new → closed

Build/Test Tools: Don't trigger the global variable override PHPCS sniff for core.

Props jrf

Fixes #43776

#3 @jorbin
8 years ago

Milestone 5.0 → 5.1

Note: See TracTickets for help on using tickets.

Download in other formats: