WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#43776 closed defect (bug) (fixed)

CS: minor adjustment to the PHPCS ruleset

Reported by: jrf's profile jrf Owned by: johnbillion's profile johnbillion
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.1
Component: Build/Test Tools Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

The reference to the WordPress.Variables.GlobalVariables sniff needs to be removed from the ruleset.

This sniff is not included in the WordPress-Core ruleset as Core writing to Core global variables is fine (of course).

Passing the custom properties which are needed by themes and plugins, activates the sniff needlessly.

Related: #43764 - see https://core.trac.wordpress.org/ticket/43764#comment:1

Attachments (1)

43776-wpcs-ruleset-adjustment.patch​ (1.4 KB) - added by jrf 6 years ago.

Download all attachments as: .zip

Change History (4)

@jrf
6 years ago

#1 @netweb
6 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.0

👍

#2 @johnbillion
6 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 43013:

Build/Test Tools: Don't trigger the global variable override PHPCS sniff for core.

Props jrf

Fixes #43776

#3 @jorbin
6 years ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.