#43800 closed enhancement (fixed)
Unnecessary <br /> tag in a note on the category page.
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | 4.9.5 |
Component: | Taxonomy | Keywords: | has-screenshots has-patch ui-feedback |
Focuses: | ui | Cc: |
Description
An unnecessary <br /> element produces a line break in a note on the Category page.
The description should be appear only after 'Note:'
Please have a look on the attachment.
Attachments (12)
Change History (21)
#2
@
7 years ago
thanks @jainnidhi for patch
I had already added the space to my first patch.
But I think its not a right way.
#3
@
7 years ago
see wp-admin\includes\network.php
echo '<div class="updated inline"><p><strong>' . __( 'Note:' ) . '</strong> ';
space is used.
#4
@
7 years ago
- Milestone changed from Awaiting Review to 5.0
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
#5
@
7 years ago
To my eyes, there are two notes here, which is why there are two separate paragraphs.
Running in the first note as suggested by the current patch leaves the second one hanging.
Better, perhaps to change the text to "Notes:" and keep the line break.
Alternatively merge both notes into a single paragraph preceded by "Note:" and ignore the fact that the text refers to two different issues.
@
6 years ago
Hey, just tested and works well. I agree with @mdgl about bumping up the second line so that it's one single paragraph. Here's that change attached.
@
6 years ago
Apologies for the confusion: I had mistakenly edited the wrong edit-tags.php
file under "build" instead of "src" so my changes weren't shown in my previous attachment. Please test this diff instead.
#6
@
6 years ago
Thank you for the updated patch, @joanrho!
Rather than removing just the <br />
tag, let's remove the entire Note:
. When editing tags, there's also a comment about converting tags to categories, but it doesn't have the Note
prefix.
@
6 years ago
Remove "Note:" text to align with the descriptive text styles on the Tags page and reintroduce paragraphs to clarify and separate the two different topics.
Removed <br /> element and added a space