WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 8 weeks ago

#43800 reviewing enhancement

Unnecessary <br /> tag in a note on the category page.

Reported by: pratikthink Owned by: SergeyBiryukov
Milestone: 5.0 Priority: normal
Severity: normal Version: 4.9.5
Component: Taxonomy Keywords: has-screenshots has-patch ui-feedback
Focuses: ui Cc:

Description

An unnecessary <br /> element produces a line break in a note on the Category page. The description should be appear only after 'Note:'
Please have a look on the attachment.

Attachments (7)

Categories-Note-before.jpg (64.7 KB) - added by pratikthink 2 months ago.
Categories - Note after patch.jpg (64.6 KB) - added by pratikthink 2 months ago.
43800.diff (561 bytes) - added by pratikthink 2 months ago.
Removed <br /> element and added a space
43800.1.diff (595 bytes) - added by jainnidhi 2 months ago.
43800.2.diff (596 bytes) - added by jainnidhi 2 months ago.
43800.3.patch (593 bytes) - added by pratikthink 2 months ago.
added &nbsp; Just after Note:
43800.4.diff (588 bytes) - added by pratikthink 2 months ago.
added space and removed nbsp

Download all attachments as: .zip

Change History (12)

@pratikthink
2 months ago

Removed <br /> element and added a space

@jainnidhi
2 months ago

#1 @pratikthink
2 months ago

  • Component changed from Text Changes to Taxonomy

@jainnidhi
2 months ago

#2 @pratikthink
2 months ago

thanks @jainnidhi for patch
I had already added the space to my first patch.

But I think its not a right way.

@pratikthink
2 months ago

added &nbsp; Just after Note:

#3 @pratikthink
2 months ago

see wp-admin\includes\network.php

echo '<div class="updated inline"><p><strong>' . __( 'Note:' ) . '</strong> ';


space is used.

@pratikthink
2 months ago

added space and removed nbsp

#4 @SergeyBiryukov
2 months ago

  • Milestone changed from Awaiting Review to 5.0
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 @mdgl
8 weeks ago

To my eyes, there are two notes here, which is why there are two separate paragraphs.

Running in the first note as suggested by the current patch leaves the second one hanging.

Better, perhaps to change the text to "Notes:" and keep the line break.

Alternatively merge both notes into a single paragraph preceded by "Note:" and ignore the fact that the text refers to two different issues.

Note: See TracTickets for help on using tickets.