WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#43803 closed enhancement (fixed)

Change all the occurrences of `(opens in a new window)` to `(opens in a new tab)`

Reported by: afercia Owned by: SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Administration Keywords: good-first-bug has-patch
Focuses: accessibility Cc:

Description

Today, it's very likely that browsers will open links with a target="_blank" attribute in a new browser's tab rather than in a new window. It is true that this depends also on user settings, but in the vast majority of the cases they will open in a new tab.

Considering also the propsed change in Gutenberg, see https://github.com/WordPress/gutenberg/pull/6245, I'd propose to just change "window" to "tab".

Attachments (2)

43803.diff (6.7 KB) - added by chetan200891 3 years ago.
Created inital patch to change text from "window" to "tab".
43803.2.diff (4.9 KB) - added by ianbelanger 3 years ago.

Download all attachments as: .zip

Change History (11)

#1 @SergeyBiryukov
3 years ago

  • Keywords good-first-bug added

@chetan200891
3 years ago

Created inital patch to change text from "window" to "tab".

#2 @chetan200891
3 years ago

  • Keywords has-patch added; needs-patch removed

Added initial patch to change text from "opens in a new window" to "opens in a new tab".

#3 @ianbelanger
3 years ago

I had a little trouble applying the patch so I created one with the same changes.

@ianbelanger
3 years ago

#4 @webzunft
3 years ago

Checked the patch (43803.2.diff) and it does what it was supposed to. No other occurrences of "opens in a new window" found.

#5 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 43174:

Administration: Change all the occurrences of "(opens in a new window)" to "(opens in a new tab)".

Props chetan200891, ianbelanger, afercia.
Fixes #43803.

#6 @audrasjb
2 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 4.9.9 consideration as seen during accessibility team bug-scrub meeting.

#7 @SergeyBiryukov
2 years ago

  • Milestone changed from 5.0 to 4.9.9

#8 @pento
2 years ago

  • Keywords fixed-major removed
  • Milestone changed from 4.9.9 to 5.1
  • Resolution set to fixed
  • Status changed from reopened to closed

This is fine to be released in 5.1.

#9 @afercia
2 years ago

In 44655:

Build/Test Tools: Update QUnit index file after [43174].

Updates the last occurrence of "(opens in a new window)" to "(opens in a new tab)".

See #43803.

Note: See TracTickets for help on using tickets.