WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 5 days ago

#43829 closed enhancement (fixed)

[proposal] Add unit test for Japanese language

Reported by: ryotsun Owned by: johnbillion
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-unit-tests has-patch
Focuses: Cc:

Description

I propose to add unit test for Japanese language.
It may help countries which have multi-byte characters like east asian countries.

At the beginning, I added unit test for Japanese language referred from German's.
After this is approved, I will also add more Japanese-specific unit test.

Attachments (1)

43829_1.patch (8.8 KB) - added by ryotsun 2 months ago.

Download all attachments as: .zip

Change History (9)

@ryotsun
2 months ago

#1 @miyauchi
2 months ago

+1

It is very nice for us.

I want to open some tickets to improve some enhancement for Chinese, Korean and Japanese after this ticket will be merged. For example, there is half-width space and full-width space in those languages, so we should be able to use full-width space as a separator of search keyword.

This ticket was mentioned in Slack in #polyglots by miyauchi. View the logs.


2 months ago

#4 @johnbillion
5 weeks ago

  • Milestone changed from Awaiting Review to 5.0
  • Owner set to johnbillion
  • Status changed from new to reviewing
  • Version trunk deleted

#5 @ryotsun
2 weeks ago

Related ticket: #44296

Last edited 6 days ago by SergeyBiryukov (previous) (diff)

#6 @miyauchi
7 days ago

We wrote a unit test for WP Multibyte Patch on GitHub. https://github.com/jawordpressorg/automated-testing-for-wordpress-ja

There are descriptions what is multibyte patch doing in README.md on this repository. (There are no official documentation in English for this plugin.)

I want to open some tickets to add tests based on the repo after this ticket will be merged.

Related: https://meta.trac.wordpress.org/ticket/3163

#7 @miyauchi
7 days ago

There is a list of the locales that include custom plugin in the package. https://meta.trac.wordpress.org/ticket/3163#comment:10

#8 @johnbillion
5 days ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 43359:

I18N: Introduce unit tests for the Japanese language in order to facilitate future improvements.

Props ryotsun

Fixes #43829

Note: See TracTickets for help on using tickets.