Make WordPress Core

Opened 6 years ago

Closed 4 years ago

#43831 closed enhancement (wontfix)

parse_order method of WP_Query class.

Reported by: rnaby's profile rnaby Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Query Keywords: has-patch
Focuses: Cc:

Description

the parse_order method of WP_Query class can be rewritten like this patch.

Attachments (1)

43831.diff (660 bytes) - added by rnaby 6 years ago.
The patch for the issue.

Download all attachments as: .zip

Change History (3)

@rnaby
6 years ago

The patch for the issue.

#1 @pento
5 years ago

  • Version trunk deleted

#2 @SergeyBiryukov
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Hi there, thanks for the patch! Sorry it took so long for someone to get back to it.

The existing code looks a bit clearer to me, and is more consistent with the same method in other classes:

  • WP_Comment_Query::parse_order()
  • WP_Network_Query::parse_order()
  • WP_Site_Query::parse_order()
  • WP_Term_Query::parse_order()
  • WP_User_Query::parse_order()
Note: See TracTickets for help on using tickets.