WordPress.org

Make WordPress Core

Opened 14 months ago

Last modified 4 weeks ago

#43836 assigned defect (bug)

Update or patch getID3 library

Reported by: sanchothefat Owned by: joemcgill
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Media Keywords: needs-patch
Focuses: Cc:

Description

The getID3 library is a little out of date now and currently has the following defect.

File names are sanitised in such a way that a double slash (or directory separator) eg. // is replaced by a single instance of that character.

For file stream wrappers this is broken because a path like s3://example is changed to s3:/example.

The latest version of the library doesn't have this issue (the offending line is commented out) but requires PHP 5.3.

We should patch the offending line or update the entire library.

Attachments (1)

43836.patch (591 bytes) - added by sanchothefat 14 months ago.
Basic patch, removes offending line

Download all attachments as: .zip

Change History (6)

@sanchothefat
14 months ago

Basic patch, removes offending line

#1 @sanchothefat
14 months ago

  • Keywords has-patch added; needs-patch removed

#2 @swissspidy
10 months ago

#44819 was marked as a duplicate.

#3 @pento
5 months ago

  • Version trunk deleted

#4 @joemcgill
2 months ago

  • Milestone changed from Awaiting Review to 5.3
  • Owner set to joemcgill
  • Status changed from new to assigned

The latest version of the getID3 library as of today is 1.9.17. The version shipped in core is 1.9.14 since [41196]. Let's update the whole library to the latest version rather than patching specific issues.

#5 @desrosj
4 weeks ago

  • Keywords needs-patch added; has-patch removed
Note: See TracTickets for help on using tickets.