WordPress.org

Make WordPress Core

Opened 19 months ago

Closed 2 months ago

Last modified 2 months ago

#43836 closed defect (bug) (fixed)

Update or patch getID3 library

Reported by: sanchothefat Owned by: joemcgill
Milestone: Priority: normal
Severity: normal Version:
Component: Media Keywords: needs-testing has-patch
Focuses: Cc:
PR Number:

Description

The getID3 library is a little out of date now and currently has the following defect.

File names are sanitised in such a way that a double slash (or directory separator) eg. // is replaced by a single instance of that character.

For file stream wrappers this is broken because a path like s3://example is changed to s3:/example.

The latest version of the library doesn't have this issue (the offending line is commented out) but requires PHP 5.3.

We should patch the offending line or update the entire library.

Attachments (2)

43836.patch (591 bytes) - added by sanchothefat 19 months ago.
Basic patch, removes offending line
43836.diff (371.3 KB) - added by desrosj 3 months ago.

Download all attachments as: .zip

Change History (13)

@sanchothefat
19 months ago

Basic patch, removes offending line

#1 @sanchothefat
19 months ago

  • Keywords has-patch added; needs-patch removed

#2 @swissspidy
15 months ago

#44819 was marked as a duplicate.

#3 @pento
10 months ago

  • Version trunk deleted

#4 @joemcgill
7 months ago

  • Milestone changed from Awaiting Review to 5.3
  • Owner set to joemcgill
  • Status changed from new to assigned

The latest version of the getID3 library as of today is 1.9.17. The version shipped in core is 1.9.14 since [41196]. Let's update the whole library to the latest version rather than patching specific issues.

#5 @desrosj
6 months ago

  • Keywords needs-patch added; has-patch removed

#6 @desrosj
4 months ago

  • Keywords needs-refresh added; needs-patch removed

@desrosj
3 months ago

#7 @desrosj
3 months ago

  • Keywords needs-testing has-patch added; needs-refresh removed

43836.diff updates the entire library to 1.9.17. I have a test branch on my fork passing Travis.

There are some additional classes that are not included in WordPress. I'm assuming they are not included because core does not utilize them. Maybe someone with a little historical knowledge can weigh in.

#9 @jrf
2 months ago

Updating to 1.9.17 is not a good idea as there are PHP 7.4 related issues in the code which have not yet been addressed in 1.9.17.

The current master has been fixed for those issues and I've opened an issue asking the maintainer to tag a new release: https://github.com/JamesHeinrich/getID3/issues/200

#10 @desrosj
2 months ago

  • Milestone 5.3 deleted
  • Resolution set to duplicate
  • Status changed from assigned to closed

While not directly a duplicate, #47751 (more specifically [46112]) has updated the getID3 library to the latest version, which is now 1.9.18 and includes PHP 7.4 compatibility issues.

#11 @jorbin
2 months ago

  • Resolution changed from duplicate to fixed

In 46166:

External Library: Update getid3 to 1.9.18

Follow up to r46112 as getid3 has tagged an official release.

Changes: https://github.com/JamesHeinrich/getID3/compare/00f3fbfd77e583099ca70a3cf0bc092e113d2b20...v1.9.18

Props desrosj, jkitchen.
Fixes #47751 #40883 #43836.

Note: See TracTickets for help on using tickets.