Update or patch getID3 library

[sanchothefat]

The getID3 library is a little out of date now and currently has the following defect.

File names are sanitised in such a way that a double slash (or directory separator) eg. // is replaced by a single instance of that character.

For file stream wrappers this is broken because a path like s3://example is changed to s3:/example.

The latest version of the library doesn't have this issue (the offending line is commented out) but requires PHP 5.3.

We should patch the offending line or update the entire library.

[sanchothefat]

Basic patch, removes offending line

[swissspidy]

#44819 was marked as a duplicate.

[joemcgill]

The latest version of the getID3 library as of today is 1.9.17. The version shipped in core is 1.9.14 since [41196]. Let's update the whole library to the latest version rather than patching specific issues.

[desrosj]

For reference, here is a list of commits since 1.9.14: ​https://github.com/JamesHeinrich/getID3/compare/v1.9.14...v1.9.17

Also, the changelog: ​https://github.com/JamesHeinrich/getID3/blob/master/changelog.txt.

[desrosj]

43836.diff​ updates the entire library to 1.9.17. I have a ​test branch on my fork passing Travis.

There are some additional classes that are not included in WordPress. I'm assuming they are not included because core does not utilize them. Maybe someone with a little historical knowledge can weigh in.

[jrf]

Also see: https://core.trac.wordpress.org/ticket/47751#comment:6

[jrf]

Updating to 1.9.17 is not a good idea as there are PHP 7.4 related issues in the code which have not yet been addressed in 1.9.17.

The current master has been fixed for those issues and I've opened an issue asking the maintainer to tag a new release: ​https://github.com/JamesHeinrich/getID3/issues/200

[desrosj]

While not directly a duplicate, #47751 (more specifically [46112]) has updated the getID3 library to the latest version, which is now 1.9.18 and includes PHP 7.4 compatibility issues.

[jorbin]

In 46166:

External Library: Update getid3 to 1.9.18

Follow up to r46112 as getid3 has tagged an official release.

Changes: ​https://github.com/JamesHeinrich/getID3/compare/00f3fbfd77e583099ca70a3cf0bc092e113d2b20...v1.9.18

Props desrosj, jkitchen.
Fixes #47751 #40883 #43836.

[stokim]

Hi @jorbin
getid3 was updated on Dec 2019 to 1.9.19, and this is the latest version with many bug fixes.
v1.9.19
@JamesHeinrich JamesHeinrich released this on Dec 18, 2019 · 49 commits to master since this release

1.9.19: [2019-12-17] James Heinrich :: 1.9.19-201912131005

add placeholder support for WTV (Windows Recorded TV Show)
bugfix (G:210) PHP 7.4 deprecated get_magic_quotes
bugfix (G:207) improved LAME version string parsing
bugfix (G:206) inverted logic in CopyTagsToComments
bugfix (G:203) use getimagesizefromstring if available
Quicktime decode 'uuid' atom for 360fly cameras
=========================================================================================
I hope it will be reflected in the next update.
Many thanks :)

[SergeyBiryukov]

#40883 was marked as a duplicate.