Make WordPress Core

Opened 8 years ago

Last modified 2 months ago

#43842 new enhancement

get_children() function enhancement.

Reported by: rnaby's profile rnaby Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Query Keywords: has-patch needs-refresh reporter-feedback
Focuses: Cc:

Description

This get_children function can be rewritten this way. And I think this is cleaner and better.

Attachments (1)

43842.diff (1.9 KB) - added by rnaby 8 years ago.
The refactored get_children function patch.

Download all attachments as: .zip

Change History (3)

@rnaby
8 years ago

The refactored get_children function patch.

#1 @pento
7 years ago

  • Version trunk deleted

#2 @huzaifaalmesbah
2 months ago

  • Keywords needs-refresh reporter-feedback added; needs-testing removed

I attempted to apply the attached patch (43842.diff) against current trunk (7.0-alpha), but it does not apply cleanly.

Patch results:

  • src/wp-includes/post.php → hunk failed (.rej created)

Since the patch cannot be applied, testing is not currently possible. Because of this, keeping needs-testing is not meaningful until the patch is refreshed and rebased to trunk.

Removing needs-testing and adding needs-refresh.

Also noting that this ticket is quite old (~8 years) and proposes a refactor/cleanup rather than addressing a regression. It would be helpful to get reporter/maintainer feedback on whether this enhancement is still needed before investing time refreshing the patch.

Note: See TracTickets for help on using tickets.