WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#43847 closed enhancement (wontfix)

Cleaned "handle_featured_media" method of "WP_REST_Posts_Controller" class.

Reported by: rnaby's profile rnaby Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: REST API Keywords: has-patch needs-testing
Focuses: Cc:

Description

Cleaned handle_featured_media method of WP_REST_Posts_Controller class. I think this is more cleaner approach.

Attachments (1)

43847.diff​ (940 bytes) - added by rnaby 5 years ago.
The patch for the enhancement.

Download all attachments as: .zip

Change History (3)

@rnaby
5 years ago

The patch for the enhancement.

#1 @pento
4 years ago

  • Version trunk deleted

#2 @TimothyBlynJacobs
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Hi @rnaby,

Thank you for taking the time to work on a patch! Typically refactoring patches don't get accepted. In this case, I also don't think that the updated version is substantially more clean than the current version. So I'm going to close this ticket for now.

​https://make.wordpress.org/core/handbook/contribute/code-refactoring/

Note: See TracTickets for help on using tickets.