Fix spacing on responsive for Use This Page button in Privacy Tools

[PressTigers]

Hi,

On Privacy page, page drop down and button should be properly aligned from top bottom on the small devices.

Also attached screenshot. Please have a look.

Thanks & Regards,
PressTigers

[PressTigers]

Padding issue needs to be fixed

[xkon]

Hey @PressTigers welcome to trac and thank you for noticing this! Also thanks @abdullahramzan for tagging gdpr here :).

43852.diff​ adds a margin in max-width: 782px screens as seen in 43852.jpg​

[PressTigers]

Thanks @xkon ,

Tested the patch. It looks good now. But do you thing there should be some space between the drop-down page and the text "Either select an existing page:".

Best Regards,
PressTigers

[PressTigers]

Page drop-down and button should also be aligned. Please review the attached screenshot.

I will submit the patch for this fix soon.

Thanks

[PressTigers]

Alignment issue for Dropdown page and Use This Page button

[PressTigers]

Left Alignment Fix

[PressTigers]

Left alignment looks better now

[abdullahramzan]

Tested the patch, it works fine for me.

@SergeyBiryukov can you please review the patch updated by @PressTigers

Thanks

[xkon]

@PressTigers thanks for the update & you're correct on the spacing between Either select an existing page and the input as well. Usually all forms tend to be inside <tables> so the <td> are giving a 4px top spacing as far as I could check (I was checking the Settings -> General page for example).

You want to update the patch and check that as well? No need to add tables of course just a little bit of spacing there to make it look even with the rest of the Admin.

[PressTigers]

@xkon ,

Yeah, I will update the patch soon.

Regards,

[PressTigers]

Fix spacing

[PressTigers]

@xkon ,

Can you please review the patch https://core.trac.wordpress.org/attachment/ticket/43852/43852-2.diff? It looks good now.

[xkon]

@PressTigers yup it looks good, thank you!

@desrosj 43852-2.diff​ addresses some padding issues and fixes them as seen in latest_preview.jpg​ . Could we get this in asap as it's a small change and we have 2-3 more tickets for this screen as well to avoid doing the same fixes?

[desrosj]

The screen still feels like the spacing is inconsistent to me (which it is slightly). In 43852.2.diff​ I applied the same margin to both elements and it feels a bit better.

[xkon]

Looks good @desrosj !

[abdullahramzan]

@desrosj ,

I think "Use This Page" button margin-top should be 10px.

[desrosj]

@abdullahramzan are you not seeing that when testing the most recent patch (Shot 2018-04-28 at 9.50.36 AM.png)? When the most recent patch is applied, I am seeing the correct margin applied: ​https://cloudup.com/cxVWpXJeJ8c.

[xkon]

After bug scrubs re-tested and this looks ok to me @desrosj just like your screenshot.

[abdullahramzan]

@desrosj @xkon,

Yeah, it looks good to me. The major concern is spacing should be equal between the Select input and "Use This Page" button and the space between the "Use This Page" button and Create New Page. Maybe I am wrong.

[melchoyce]

@desrosj Your screenshot looks good to me!

[PressTigers]

@desrosj, @melchoyce ,

Tested! Looks good.

[azaozz]

In 43193:

Privacy: fix spacing on small screens for the Use This Page button in Privacy Tools.

Props PressTigers, desrosj.
Fixes #43852.

[azaozz]

In 43194:

Privacy: fix spacing on small screens for the Use This Page button in Privacy Tools.

Props PressTigers, desrosj.
Merges [43193] to the 4.9 branch.
Fixes #43852.

[desrosj]

Moving to the new Privacy component.