Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #43862, comment 9


Ignore:
Timestamp:
06/06/2018 03:07:20 PM (7 years ago)
Author:
dougwollison
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #43862, comment 9

    v2 v3  
    11While it's possible that I've been using it wrong, I just now stumped across an arguably breaking change caused by TinyMCE 4.7.
    22
    3 It seems that the SetupEditor event, which originally passed the editor instance directly as the single callback argument, now passes an event object containing it. It's a simply matter to fix (`var editor = e.editor || e;`), but I can't be the only one who's code hooks into TinyMCE via SetupEditor. I admit I haven't thoroughly read TinyMCE's changelog, but a cursory glance makes no mention of this change to the API, aside from fixing the Compat3x plugin to account for it.
    4 
    5 As for why it took me 3 weeks to notice... I got nuthin; I was pre-occupied with other projects, and apparently none of my clients or plugin users have encountered it until today.
     3Edit: moved to ticket:44134#comment:20