WordPress.org

Make WordPress Core

Opened 18 months ago

Closed 18 months ago

Last modified 17 months ago

#43865 closed enhancement (wontfix)

Privacy Policy Tools Page: Improve readability

Reported by: birgire Owned by: desrosj
Milestone: Priority: low
Severity: minor Version: 5.1
Component: Privacy Keywords: gdpr has-screenshots ui-feedback has-patch needs-testing close
Focuses: ui, administration Cc:
PR Number:

Description

The text lines on the Tools > Privacy page can get very long on large devices.

This is a general problem in wp-admin, but I wonder if we could consider e.g. adding a max-width or splitting it into more paragraphs on this page.

I would also suggest removing the horizontal line there, imho this extra visual separation is not needed. Also if other setting sections would be added later, then the horizontal line might not be suitable.

The file is: /wp-admin/privacy.php.

Attachments (11)

privacy-policy-before.jpg (33.5 KB) - added by birgire 18 months ago.
privacy-policy-max-width-and-no-horizontal-line.jpg (49.5 KB) - added by birgire 18 months ago.
privacy-policy-more-paragrahps.jpg (29.2 KB) - added by birgire 18 months ago.
43865-1.diff (1.7 KB) - added by seusmaniqbal 18 months ago.
Set max-width for privacy page content readability
43865.jpg (346.3 KB) - added by xkon 18 months ago.
43865.diff (3.5 KB) - added by xkon 18 months ago.
43865.2.png (71.0 KB) - added by xkon 18 months ago.
43865.2.diff (4.4 KB) - added by xkon 18 months ago.
43865.3.diff (1.9 KB) - added by birgire 18 months ago.
43865.4.jpg (259.8 KB) - added by xkon 18 months ago.
43865.4.diff (3.2 KB) - added by xkon 18 months ago.

Download all attachments as: .zip

Change History (43)

#1 @birgire
18 months ago

  • Type changed from defect (bug) to enhancement

#2 @birgire
18 months ago

  • Keywords ui-feedback added; 2nd-opinion removed

#3 @birgire
18 months ago

  • Keywords gdpr added

#4 @seusmaniqbal
18 months ago

Hi @birgire,

Thank you for noticing this. It's a readability issue on large devices. I am taking this ticket and adding a patch shortly.

Regards,

#5 @idea15
18 months ago

@birgire Which ticket is the language from?

#6 @birgire
18 months ago

@idea15 It seems to be from this changeset [42978]. Will this text be changed?

@seusmaniqbal Let's see if the text will change and maybe the lines then will get shorter then. What do you think about the horizontal line?

#7 @idea15
18 months ago

@birgire yes please

#8 @xkon
18 months ago

@birgire There's also #43852 that fixes some responsive / padding issues ( for this screen ) but it's not touching the text. Just fyi.

#9 @xkon
18 months ago

@birgire / @seusmaniqbal please either see https://core.trac.wordpress.org/ticket/43435#comment:65 for the text changes or migrate this whole ticket and make a patch there instead so we can have everything together. Ty!

@seusmaniqbal
18 months ago

Set max-width for privacy page content readability

#10 @seusmaniqbal
18 months ago

  • Keywords has-patch needs-testing added

@xkon
18 months ago

@xkon
18 months ago

#11 @xkon
18 months ago

I'm still not sure if adding a max-width would make much of a difference, especially on big screens.

I personally prefer the <p> idea of @birgire even though still they are 'lenghty' dividing them makes it easier to follow and we don't go off the way the admin area works.

--

43865.diff

  • changes Privacy Policy to Privacy Notice
  • changes the menu link to Privacy Notice Page - there is no reason having it as Privacy since the tools got divided into their own pages.
  • Removes the false title Privacy Tools - the only thing in this page is the Page Creation so that title doesn't make sense any more imho.
  • Removes the <hr>
  • Adds the new text from https://core.trac.wordpress.org/ticket/43435#comment:65
  • Adds extra <p> on text for readability.

@webdevlaw can you confirm this from the preview of 43865.jpg ?

Also on an extra note below are more changes that you requested ( I'm transfering theme here for ease of use ). I skiped these as this page has nothing to do with 'Privacy Tools' anymore as the only thing it does is the Privacy Policy select/create option, and that is confusing. We could add those into each individual page that fits ( Export / Delete etc ).

Change: This page provides tools with which you can manage your user\'s personal data and site\'s privacy policy.'

To:

This page provides tools to help you manage your site's privacy settings and compliance requirements.

The privacy notice tool will help you to draft a privacy notice that meets European data protection law requirements.

The personal data tool will allow your European users to request and export a copy of their personal data.

--

Do we have anything to add on the Help above? FYI the Export Data / Delete Data tools don't have any Help API set at the moment. So we should either add something on all off them that is about each respective page or remove it for now imho. There's no point of having double content atm.

This ticket was mentioned in Slack in #gdpr-compliance by xkon. View the logs.


18 months ago

#13 @audrasjb
18 months ago

  • Milestone changed from Awaiting Review to 4.9.6

#14 @azaozz
18 months ago

Thinking this should just be max-width in CSS.

#15 @idea15
18 months ago

@xkon Up at the top -

"This page provides tools with which you can manage your user's personal data and site's privacy policy"

should be

"This page provides tools to draft your site's privacy notice and manage your users' personal data."

@xkon
18 months ago

@xkon
18 months ago

#16 @xkon
18 months ago

43865.2.diff continues on @seusmaniqbal patch keeping the max-width settings. See 43865.2.png :

  • Changes the menu link to Privacy Policy Page
  • Replaces the general title Privacy Tools with Privacy Policy Page again to match the menu
  • Removes the <hr>
  • Replaces the text with the new from https://core.trac.wordpress.org/ticket/43435#comment:65 (some adjustments made to be consistent with Privacy Policy etc)
  • Replaces the 'Help' text to explain what this page does

This ticket was mentioned in Slack in #gdpr-compliance by azaozz. View the logs.


18 months ago

#18 @xkon
18 months ago

The text and other various fixes will be handled in other tickets.

For a review and to move this forward please use and see the 43865-1.diff patch from @seusmaniqbal .

@birgire
18 months ago

#19 @birgire
18 months ago

@seusmaniqbal and @xkon thank you for working on this.

Since the text modificaitons will take place in #43435, I added the patch 43865.3.diff based on 43865-1.diff. It further:

  • Uses the existing 1120px breaking point, to add 80% max width on the descriptions.
  • Changed the CSS comments into a single line, and removed the command regarding "normal" screen size.
  • Removes the horizontal rule <hr>.

This ticket was mentioned in Slack in #gdpr-compliance by desrosj. View the logs.


18 months ago

#21 @desrosj
18 months ago

  • Owner set to desrosj
  • Status changed from new to assigned

This ticket was mentioned in Slack in #gdpr-compliance by desrosj. View the logs.


18 months ago

@xkon
18 months ago

@xkon
18 months ago

#23 @xkon
18 months ago

43865.4.diff continues from 43865.3.diff and re-arranges the <table> to look more like a settings table as discussed in the latest bug scrubs.

As seen in 43865.4.jpg the page looks cleaner with this change and more in-line with the Admin in general imho.

@birgire what do you think of this ?

This ticket was mentioned in Slack in #gdpr-compliance by xkon. View the logs.


18 months ago

#25 @melchoyce
18 months ago

I don't mind adding a max-width — line-length and readability are really important to consider, now that we have copy — but the two options on the page were specifically designed to fall under one settings section because otherwise, they look like two separate settings. Presenting them as two options makes it seem like you need to fill both of them out, when really, it's an either/or option. Let's change that back to how it was, please.

#26 @xkon
18 months ago

Even if it's explained on the text above? ( the new copy is in another ticket that explains that you have to select either or ) just mentioning in case https://core.trac.wordpress.org/ticket/43435#comment:79 ...

If not can we at least make the <th> bigger? that 'page' that is making the title a 2 liner just wants me to cry.

If not, well just skip my patch and use only @birgire 's but that 'page' from 'Change your Privacy Policy page' just has to go.

#27 follow-up: @melchoyce
18 months ago

Even if it's explained on the text above?

Yes — because that requires people to both read and absorb the above copy, which isn't guaranteed.

If not can we at least make the <th> bigger? that 'page' that is making the title a 2 liner just wants me to cry.
If not, well just skip my patch and use only @birgire 's but that 'page' from 'Change your Privacy Policy page' just has to go.

That copy can definitely use some tweaking. However, I wouldn't change the font size — which should be standardized with the rest of the settings screens — just to adjust how the copy falls onto a new line on larger screens.

#28 in reply to: ↑ 27 @xkon
18 months ago

Replying to melchoyce:

I wouldn't change the font size

Sorry fast thinking translation on my last comment:

make <th> bigger = Not play with font size but make the 1st column a bit wider (10px to be exact) so it doesn't break the sentence for only 1 word :D we're either way adding extra css for our uses an extra 1liner class wouldn't matter much I think, would that still 'break the rules' here? :)

Basically from width: 200px -> width: 210px;

#29 @melchoyce
18 months ago

Let's see if we can update the label. However, I tend to find chasing down exact line-breaks to be kind of a fruitless exercise — the web is so dynamic and different browsers/devices render things differently enough that you can't ever be guaranteed the result you want.

#30 @azaozz
18 months ago

  • Keywords close added

Ugh, why is this screen getting redesigned? It was already done. This ticket is about "improving readability" not changing elements.

This is a general problem in wp-admin, but I wonder if we could consider e.g. adding a max-width...

I'm actually thinking this should match the rest of wp-admin. The only "tweak" here could possibly be to add max-width: 1000px although that will not match other wp-admin screens.

I would also suggest removing the horizontal line there...

No, the logical layout of this screen needs it. It was already designed and implemented, and I don't see any good reasons to redo the design.

Of course, if you're a designer and want to propose some enhancements, please go ahead! :)

#31 @birgire
18 months ago

  • Milestone 4.9.6 deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

I then mark this one as wontfix, as the design ticket of the this screen is in #43435 and the general readability of wp-admin screens can be handled as a whole in another ticket.

If I remember correctly, large horizontal lines are not displayed in wp-admin to separate sections, but that discussion can be taken to a design ticket ;-)

Thanks to all those who contributed here.

#32 @desrosj
17 months ago

  • Component changed from Administration to Privacy

Moving to the new Privacy component.

Note: See TracTickets for help on using tickets.