Chrome autofills password over "new password" field when updating user.

[WraithKenny]

Chrome, the wonderful browser that it is, is super helpful.

When editing a user (even your own), and attempting to update the password with a nice strong one, Chrome will (helpfully) insert *your* old password into the new password field, right when you click update. (You can tell, because the length of the password will change to your passwords length).

Incognito Mode fixes it, apparently, and uninstalling Chrome in favor of Firefox seems to work too.

From what I've been able to guess, it's because of Chrome's unique implementation of completely ignoring autocomplete="off" ​https://bugs.chromium.org/p/chromium/issues/detail?id=370363#c7 and suggests autocomplete="new-password" instead.

Alternatively, <form autocomplete="off"> could possibly work. ​https://stackoverflow.com/questions/15738259/disabling-chrome-autofill

It does seem to make sense to disable autocomplete completely on the edit-user form, since it's not actually useful to fill in some random user's info with info from your browser...especially passwords...despite what Chrome seems to believe.

[ayeshrajans]

Firefox 70 implements autocomplete=new-password now too, and I think this will be a nice UX improvements well.

I will submit patches for password reset and user registration fields.

[bookdude13]

This is related to #35707. If Chrome will actually respect new-password I like that approach. Turning the whole form autocomplete off is a blunt solution, but the simplicity of it is appealing...

[sabernhardt]

Also related: #52714 (for the new user screen)

Trac ticket: https://core.trac.wordpress.org/ticket/43886

[joedolson]

Looking at the ​PR and the comments on it, I think this is mostly good; but in my opinion the database password field needs to be left as autocomplete="off".

The database password is mostly a one-time use password, and unlikely to be represented in a user's keychain, so 'current-password' is most likely to suggest an invalid password, if it offers anything, and I don't believe 'new-password' would ever offer a valid suggestion, since this is not a password-generating field.

[joedolson]

Patch refreshed; database password change removed.

[sabernhardt]

43886.2.diff​ includes the New User page. If no further change is necessary for #52714, both tickets could be closed with the same commit.

[ryokuhi]

This ticket was reviewed today during the Accessibility Team's weekly bug-scrub.
I'm adding the needs-testing label, so that if the latest patch works this can be committed.

[joedolson]

Add autocomplete=off to 43886 to resolve 52714.

[joedolson]

In 53111:

Users: Use autocomplete values on user profiles.

Assign appropriate autocomplete values for new and edited user, user email, and password fields.

Props clonemykey, sabernhardt, WraithKenny, bookdude13, konradyoast.
Fixes #43886, #52714.

changes committed in revision 53111