WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #43891, comment 1


Ignore:
Timestamp:
04/28/2018 11:29:01 PM (3 years ago)
Author:
johnbillion
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #43891, comment 1

    initial v1  
    1 Thanks for the ticket and the patch, @rnaby, but I think your benchmarks are flawed. If you add `judge($a, 'reset');` to the end of the test (after `judge($a, '_reset');` you'll see that directly calling `reset()` is faster than the other methods. Your `_test()` function incurs overhead that the `reset()` function doesn't.
     1Thanks for the ticket and the patch, @rnaby, but I think your benchmarks are flawed. If you add `judge($a, 'reset');` to the end of the test (after `judge($a, '_reset');` you'll see that directly calling `reset()` is faster than the other methods. Your `_reset()` function incurs overhead that the `reset()` function doesn't.
    22
    33Can you confirm?