WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 19 months ago

#43904 new defect (bug)

Media toolbar spacing inconsistent across views

Reported by: desrosj Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Media Keywords: good-first-bug has-patch needs-testing
Focuses: ui, administration Cc:

Description

The media toolbar is present on both list and grid views. The padding on the dropdowns and buttons, though, is inconsistent.

Attachments (6)

list-view.png​ (209.9 KB) - added by desrosj 3 years ago.
Note the scrunched dropdowns/buttons
grid-view.png​ (943.2 KB) - added by desrosj 3 years ago.
Note the nicely spaced dropdowns and buttons
43904.1.diff​ (501 bytes) - added by seusmaniqbal 3 years ago.
Set margin for Media toolbar dropdowns
43904.1.svn.diff​ (386 bytes) - added by ianbelanger 3 years ago.
SVN version of changes
43904-3.diff​ (88 bytes) - added by subrataemfluence 3 years ago.
43904.4.diff​ (354 bytes) - added by ianbelanger 3 years ago.
Refreshed patch and tested with current trunk

Download all attachments as: .zip

Change History (13)

@desrosj
3 years ago

Note the scrunched dropdowns/buttons

@desrosj
3 years ago

Note the nicely spaced dropdowns and buttons

@seusmaniqbal
3 years ago

Set margin for Media toolbar dropdowns

#1 @seusmaniqbal
3 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

@ianbelanger
3 years ago

SVN version of changes

#2 @ianbelanger
3 years ago

Tested patch on Lenovo ThinkPad Windows 10, in Firefox 59.0.2 and Chrome 66.0.3359.139. Changes looked good in both browsers. Also uploaded svn version of patch.

#3 @subrataemfluence
3 years ago

I applied the patch and it looks much better.

However, in order to keep the spacing consistent with media grid view the margin I believe needs to be 6px instead of 8px.

.post-type-attachment .wp-filter select {
    margin-right: 6px;
}

@subrataemfluence
3 years ago

This ticket was mentioned in ​Slack in #core by abdullahramzan. ​View the logs.
3 years ago

@ianbelanger
3 years ago

Refreshed patch and tested with current trunk

#5 @ianbelanger
3 years ago

  • Keywords needs-testing removed

This ticket was mentioned in ​Slack in #core by seusmaniqbal. ​View the logs.
3 years ago

#7 @ianbelanger
19 months ago

  • Keywords needs-testing added
Note: See TracTickets for help on using tickets.