WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 4 years ago

#43907 closed enhancement (fixed)

JS WordPress Coding Standards — Add Space In The Method Call

Reported by: saqibameen's profile saqibameen Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version: 5.1
Component: Comments Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

According to JS WordPress standards, there should be a space right after the opening bracket and closing bracket of the function call. However, in the 

wp-includes/js/comment-reply.js

there's no space at function call on line 161.

I am not sure if there's any other reason for being so. But all other function calls seem to follow that standard. Don't know if I am missing something? Would love to know thoughts on it.

Also, I have added the patch.

Attachments (4)

patch.diff​ (950 bytes) - added by saqibameen 7 years ago.
Patch for the ticket.
screenshot.png​ (15.6 KB) - added by saqibameen 7 years ago.
Screenshot of files difference
43907.diff​ (1.2 KB) - added by Hareesh Pillai 5 years ago.
Patch refreshed
43907.2.diff​ (743 bytes) - added by imath 4 years ago.

Download all attachments as: .zip

Change History (9)

@saqibameen
7 years ago

Patch for the ticket.

@saqibameen
7 years ago

Screenshot of files difference

#1 @pento
6 years ago

  • Version trunk deleted

#2 @Hareesh Pillai
5 years ago

  • Keywords has-screenshots removed
  • Version set to 5.1

@Hareesh Pillai
5 years ago

Patch refreshed

#3 @davidbaumwald
4 years ago

  • Keywords needs-refresh added; needs-testing removed

@hareesh-pillai I just tried to apply the patch to trunk, and it fails. Are you able to refresh this?

@imath
4 years ago

#4 @imath
4 years ago

  • Keywords commit added; needs-refresh removed
  • Milestone changed from Awaiting Review to 5.6

Hi @saqibameen

Thanks a lot for your contribution, I've just refreshed the patch: see 43907.2.diff

As you will see, some of the linting you've made in your patch have been included into this changeset [47506].

There's only one last space to add 😉

It's ready to be committed 👍

#5 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 49097:

Coding Standards: Add missing space in js/_enqueues/lib/comment-reply.js.

Props saqibameen, hareesh-pillai, imath, davidbaumwald.
Fixes #43907.

Note: See TracTickets for help on using tickets.