Improve styling on personal data tables

[allendav]

• When personal data export via email fails, the Retry button label baseline should be the same as the Email Failed! text
• The request-results row added to the table below a request should match the styles (e.g. background light blue for confirmed) for the request it is associated with.

cc @melchoyce

[allendav]

Fixes email retry baseline

[allendav]

Fixes request result row styles to blend into request row (box shadow, background, left border) for confirmed or failed requests

[allendav]

Improved styles

[allendav]

To test:

Easiest way is to add this to the top of wp_privacy_process_personal_data_export_page in wp-admin/includes/file.php near line 2261

wp_send_json_error( __( 'Wut' ) );

And then attempt to send some emails for some export requests. Be sure to try a confirmed one since it has the blue background and border.

[melchoyce]

It looks like you're not reusing existing notice classes — is there a reason you're duplicating the CSS in new classes instead of using existing classes?

[allendav]

Replying to melchoyce:

It looks like you're not reusing existing notice classes — is there a reason you're duplicating the CSS in new classes instead of using existing classes?

Hi @melchoyce ! We looked at the plugins page to mimic how it is constructed and styled and we do use .notice, .inline, .notice-alt, .notice-error from common.css on this page in the same way as the plugins page.

As for the box-shadow removal and background color copying - the styles on the plugins page are plugins table specific (in list-tables.css with things like .plugins .update td) and that's why I duplicated a tiny bit of CSS here for the requests tables.

Is that what you mean?

[melchoyce]

Ah, sorry — I noticed the margin around the notice was different from the plugin page, and then didn't see the <div class="notice inline notice-alt ' + classes + '"> in your latest patch. I think the margin above and below the notice should be narrower. I'm attaching an example based on the spacing I'm seeing in plugins.

[postphotos]

This looks good, @melchoyce and @allendav! Thank you for your work here.

[desrosj]

This is an easy win. Let's get this in right after beta.

[allendav]

Updated to tighten top and bottom margins on notices

[allendav]

Updated to tighten top and bottom margins on notices

[allendav]

@melchoyce - margins updated - thank you for the feedback!

[melchoyce]

Screenshot looks good, let's get this in.

[azaozz]

In 43216:

Privacy: fix styling on personal data tables.

Props melchoyce, allendav.
Fixes #43909.

[azaozz]

In 43217:

Privacy: fix styling on personal data tables.

Props melchoyce, allendav.
Merges [43216] to the 4.9 branch.
Fixes #43909.

[desrosj]

Moving to the new Privacy component.