WordPress.org

Make WordPress Core

Opened 18 months ago

Closed 18 months ago

Last modified 17 months ago

#43925 closed defect (bug) (fixed)

Inconsistencies in GDPR strings

Reported by: audrasjb Owned by: azaozz
Milestone: 4.9.6 Priority: normal
Severity: normal Version: 5.1
Component: Privacy Keywords: needs-testing gdpr
Focuses: Cc:
PR Number:

Description

There is a bunch of small inconsistencies in the new GDPR strings.
Especially in feedback messages during data exports, sometimes we have a trailing dot, sometimes not.

This ticket can be used to track i18n inconsistencies and fixes before 4.9.6 landing.

Attachments (4)

43925.1.diff (2.1 KB) - added by audrasjb 18 months ago.
Fixes small i18n inconsistencies in wp-admin/includes/file.php
43925.2.diff (3.2 KB) - added by audrasjb 18 months ago.
Updated i18n inconsistencies fixes
43925.3.diff (7.1 KB) - added by audrasjb 18 months ago.
@presskop enhancements + some "XXX failed!" fixes
43925.4.diff (7.8 KB) - added by audrasjb 18 months ago.
adds some context to file.php strings - thanks @presskop

Download all attachments as: .zip

Change History (20)

This ticket was mentioned in Slack in #gdpr-compliance by audrasjb. View the logs.


18 months ago

#2 @audrasjb
18 months ago

Sorry, my last patch is completely wrong, I get a GIT issue. Will upload it again in few minutes [edit: fixed]

Last edited 18 months ago by audrasjb (previous) (diff)

@audrasjb
18 months ago

Fixes small i18n inconsistencies in wp-admin/includes/file.php

@audrasjb
18 months ago

Updated i18n inconsistencies fixes

This ticket was mentioned in Slack in #polyglots by audrasjb. View the logs.


18 months ago

@audrasjb
18 months ago

@presskop enhancements + some "XXX failed!" fixes

#6 @audrasjb
18 months ago

  • Keywords needs-patch removed

Hi @Presskopp
Thank you!

In 43925.3.diff

  • @Presskopp fixes
  • replace every XXX failed! strings with more accurate sentences.

Feel free to add any other i18n issues!

Cheers,
Jb

#7 @subrataemfluence
18 months ago

  • Keywords has-patch added

#8 @audrasjb
18 months ago

  • Keywords has-patch removed

Removing has-patch keyword since we are waiting for polyglot teams feedbacks.

This ticket was mentioned in Slack in #polyglots by audrasjb. View the logs.


18 months ago

@audrasjb
18 months ago

adds some context to file.php strings - thanks @presskop

This ticket was mentioned in Slack in #gdpr-compliance by audrasjb. View the logs.


18 months ago

#12 @birgire
18 months ago

Here are some notes

https://core.trac.wordpress.org/ticket/43438#comment:43

about string consistency in wp_ajax_wp_privacy_export_personal_data() and wp_ajax_wp_privacy_erase_personal_data() that might belong here?

Last edited 18 months ago by birgire (previous) (diff)

#13 @azaozz
18 months ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 43118:

Privacy: fix inconsistencies in new strings.

Props audrasjb.
Fixes #43925.

#14 @azaozz
18 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 4.9.6.

#15 @azaozz
18 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43119:

Privacy: fix inconsistencies in new strings.

Props audrasjb.
Merges [43118] to the 4.9 branch.
Fixes #43925.

#16 @desrosj
17 months ago

  • Component changed from General to Privacy

Moving to the new Privacy component.

Note: See TracTickets for help on using tickets.