Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#43927 closed enhancement (fixed)

Filter policy help blocks away from the_content

Reported by: clorith's profile Clorith Owned by:
Milestone: 4.9.6 Priority: normal
Severity: normal Version: 5.1
Component: Privacy Keywords: gdpr
Focuses: ui Cc:


When creating a privacy policy page, we inject little help blocks that are read-only thanks to contenteditable="false". I like this, it means we have in-content help while writing, but since they're not regularly editable text fields it may not be obvious that you can remove these, or that you should remove them.

Could we perhaps introduce a filter for the_content that runs and removes these before the page is output?

Change History (9)

#1 @swissspidy
6 years ago

I haven't looked at the code, but would it be possible to not save these help blocks in the first place? Makes more sense to me.

This ticket was mentioned in Slack in #gdpr-compliance by clorith. View the logs.

6 years ago

#3 @Clorith
6 years ago

Not saving them means you'd have to write everything in one sitting, as you would then lose them when you return. I can see this going both ways though.

#4 @Clorith
6 years ago

#43971 was marked as a duplicate.

#5 @azaozz
6 years ago

Yeah, was thinking about this too. If we keep the tutorial "blocks" (with contenteditable="false") in post_content (which is currently not the case), we may need to make sure they are kept on saving a draft and deleted on publishing.

Ideally the users will delete them before publishing, but we can "make sure" and have a filter that removes them too. Don't think we will need a "display filter", we can remove the tutorials on publishing and updating a published post.

#6 @azaozz
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [43203].

This ticket was mentioned in Slack in #gdpr-compliance by garrett-eclipse. View the logs.

6 years ago

#8 @desrosj
6 years ago

  • Component changed from Administration to Privacy

Moving to the new Privacy component.

#9 @netweb
6 years ago

  • Milestone changed from Awaiting Review to 4.9.6
Note: See TracTickets for help on using tickets.