WordPress.org

Make WordPress Core

Opened 3 weeks ago

Closed 3 weeks ago

Last modified 9 days ago

#43935 closed enhancement (fixed)

Limit Privacy Policy screen to Super Admins in Multisite

Reported by: iandunn Owned by: iandunn
Milestone: 4.9.6 Priority: normal
Severity: normal Version:
Component: Privacy Keywords: gdpr has-patch commit
Focuses: multisite Cc:

Description

Similar to #43919, the new Privacy Policy page may not be appropriate for single-site admins in some Multisite use cases. For example, networks like WordCamp.org and WordPress.com will probably want to provide a single policy that covers all sites (using the privacy_policy_url filter). When that's done, the admin UI on individual sites becomes unnecessary, and may confuse admins when they see that their changes don't take effect.

We could follow r43085 and require a new capability for editing the privacy policy, which would be given to Administrators in single-site installs, but only to Super Administrators in Multisite installs. If the Super Admin wanted to delegate setting a privacy policy to individual site admins, they would need to use a plugin to modify the capabilities.

Are there any use cases of Multisite where that would cause a problem, or any better solutions?

Attachments (2)

43935.diff (2.7 KB) - added by iandunn 3 weeks ago.
43935.2.diff (3.1 KB) - added by desrosj 3 weeks ago.
Change capability to manage_privacy_options

Download all attachments as: .zip

Change History (19)

@iandunn
3 weeks ago

#1 @iandunn
3 weeks ago

  • Keywords has-patch dev-feedback added; needs-patch removed

I think 43935.diff is ready for commit, but would like a second pair of eyes just to make sure.

This ticket was mentioned in Slack in #gdpr-compliance by iandunn. View the logs.


3 weeks ago

This ticket was mentioned in Slack in #gdpr-compliance by desrosj. View the logs.


3 weeks ago

#4 @iandunn
3 weeks ago

The patch will probably need to be refreshed if this is committed after #43873.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


3 weeks ago

#6 @iandunn
3 weeks ago

  • Owner set to iandunn
  • Resolution set to fixed
  • Status changed from new to closed

In 43147:

Privacy: Limit Privacy Settings screen to Super Admins in Multisite.

In many common Multisite use cases, the network administrator will want to set a network-wide privacy policy -- via the privacy_policy_url filter -- for consistency and convenience. When that's done, the Privacy Settings screen on individual sites becomes unnecessary, and may confuse administrators of those sites when they see that their changes don't have any effect on the policy link in the footer.

Since we can't programatically determine which behavior the network admins would like, the safest default setting is to restrict the ability to super admins, and let them delegate it to individual site owners via a plugin, if they'd like to.

Fixes #43935.

#7 @iandunn
3 weeks ago

  • Keywords fixed-major added; needs-testing has-patch dev-feedback removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport to 4.9.

#8 @ocean90
3 weeks ago

For forward-compatibility, manage_privacy_policy doesn't sound right since the privacy policy may only one of the available privacy settings.

#9 @iandunn
3 weeks ago

@ocean90, what do you think about manage_privacy_options, or manage_privacy_settings?

If that sounds good, do you have time to commit that before the deadline? I've got my hands full with other tickets.

This ticket was mentioned in Slack in #gdpr-compliance by desrosj. View the logs.


3 weeks ago

@desrosj
3 weeks ago

Change capability to manage_privacy_options

#11 @azaozz
3 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43153:

Privacy: Limit Privacy Settings screen to Super Admins in Multisite.

In many common Multisite use cases, the network administrator will want to set a network-wide privacy policy -- via the privacy_policy_url filter -- for consistency and convenience. When that's done, the Privacy Settings screen on individual sites becomes unnecessary, and may confuse administrators of those sites when they see that their changes don't have any effect on the policy link in the footer.

Since we can't programatically determine which behavior the network admins would like, the safest default setting is to restrict the ability to super admins, and let them delegate it to individual site owners via a plugin, if they'd like to.

Merhes [43147] to the 4.9 branch.
Fixes #43935.

#12 @desrosj
3 weeks ago

  • Keywords has-patch commit added; fixed-major removed

43935.2.diff goes with manage_privacy_options instead of manage_privacy_policy . I felt that this option fell more in line with other capabilities (manage_options, manage_theme_options, manage_network_options, etc.).

#13 @desrosj
3 weeks ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#14 @azaozz
3 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43155:

Privacy: rename manage_privacy_policy to manage_privacy_options.

Props desrosj.
FIxes #43935.

#15 @azaozz
3 weeks ago

In 43156:

Privacy: rename manage_privacy_policy to manage_privacy_options.

Props desrosj.
Merges [43155] to the 4.9 branch.
Fixes #43935.

This ticket was mentioned in Slack in #gdpr-compliance by iandunn. View the logs.


2 weeks ago

#17 @desrosj
9 days ago

  • Component changed from Administration to Privacy

Moving to the new Privacy component.

Note: See TracTickets for help on using tickets.