Make WordPress Core

Opened 17 years ago

Closed 16 years ago

#4395 closed defect (bug) (fixed)

Taking out pass by reference warning

Reported by: darkfate's profile darkfate Owned by:
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.3
Component: General Keywords: needs-patch
Focuses: Cc:

Description

I saw the thing on the wp-hackers list, but I figured I'd make a trac ticket. These code standards warnings are annoying. I know you can turn them off, but I think it is better not to pass by reference since it's deprecated.

I'm just wondering why we really need it. We I take out all the pass by reference calls in wp-settings.php it seems to work...

Change History (3)

#1 @Nazgul
17 years ago

  • Keywords needs-patch added
  • Milestone changed from 2.3 (trunk) to 2.4 (future)

#2 @pishmishy
17 years ago

I've not been able to replicate this using trunk and php5. I've commented out the

allow_call_time_pass_reference = On

line in my php.ini but still don't get the error. Any pointers for me?

#3 @ryan
16 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I haven't seen any lately. Resolving as fixed. Give specific warnings if still a problem.

Note: See TracTickets for help on using tickets.