WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#43965 closed defect (bug) (fixed)

GDPR Privacy Notes Don't Play Nice with Gutenberg

Reported by: Ipstenu Owned by:
Milestone: 4.9.6 Priority: normal
Severity: normal Version: 5.1
Component: Privacy Keywords: gdpr has-patch 2nd-opinion
Focuses: Cc:

Description

After adding a page, I get the normal message:

The suggested privacy policy text has changed. Edit the privacy policy.

Click on the edit link and, if you have Gutenberg, you don't get the policy information. In addition, even if you make changes, the alert doesn't go away.

Nor does it go away if I click the dismiss button, so I have to go to the Classic Editor to make the change.

Attachments (4)

metabox_classic.png (26.5 KB) - added by xkon 2 years ago.
metabox_gutenberg.png (30.3 KB) - added by xkon 2 years ago.
43965.diff (1.3 KB) - added by xkon 2 years ago.
adds a metabox for use with Gutenberg
43965.2.diff (4.7 KB) - added by xkon 2 years ago.
fixes button actions

Download all attachments as: .zip

Change History (15)

This ticket was mentioned in Slack in #gdpr-compliance by ipstenu. View the logs.


2 years ago

#2 @xkon
2 years ago

  • Keywords gdpr added

@xkon
2 years ago

@xkon
2 years ago

adds a metabox for use with Gutenberg

#3 @xkon
2 years ago

  • Keywords has-patch 2nd-opinion added
  • Milestone changed from Awaiting Review to 4.9.6

This is something that I had done on another ticket ( #43620 ) before but our 'issue' was that since it converts to a metabox it goes underneath the Classic Editor.

I'm still in favor on doing this as many people are already using Gutenberg either way so it's nice to have.

#4 @xkon
2 years ago

Oh I forgot the css / button fixes etc.. I'll update the patch soon sorry for that! But at least you can see how it's with Gutenberg. Updated patch coming soon.

@xkon
2 years ago

fixes button actions

#5 @xkon
2 years ago

43965.2.diff

  • creates a metabox to use the policy postbox with Gutenberg
  • removes the general folding handle since the metaboxes have their own
  • relocates the js needed from post.js to postbox.js so it can work in both Classic Editor & Gutenberg

#6 @azaozz
2 years ago

We are also looking at moving the postbox content to a different page/screen as it in most cases the text there will be too long to fit "comfortably" inside the box.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


2 years ago

This ticket was mentioned in Slack in #gdpr-compliance by allendav. View the logs.


2 years ago

This ticket was mentioned in Slack in #core by desrosj. View the logs.


2 years ago

#10 @azaozz
2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed with [43203]. There is no postbox any more :)

#11 @desrosj
2 years ago

  • Component changed from General to Privacy

Moving to the new Privacy component.

Note: See TracTickets for help on using tickets.