WordPress.org

Make WordPress Core

Opened 16 months ago

Closed 16 months ago

Last modified 15 months ago

#43966 closed enhancement (fixed)

Prioritize the User group in Personal Data Exports to right below the About group

Reported by: allendav Owned by: azaozz
Milestone: 4.9.6 Priority: normal
Severity: normal Version: 5.1
Component: Privacy Keywords: gdpr has-patch commit
Focuses: Cc:

Description

Right now it can appear all the way at the bottom of the export HTML report, e.g. if WooCommerce is installed and adds things to the export, or if the user has uploaded media.

Might be as easy as setting the priority of the this hook to 0 in wp-includes/default-filters.php

add_filter( 'wp_privacy_personal_data_exporters', 'wp_register_user_personal_data_exporter' );

Attachments (2)

43966.diff (1.1 KB) - added by allendav 16 months ago.
43966.2.diff (1002 bytes) - added by desrosj 16 months ago.

Download all attachments as: .zip

Change History (14)

#1 @desrosj
16 months ago

  • Milestone changed from Awaiting Review to 4.9.6

This ticket was mentioned in Slack in #core by desrosj. View the logs.


16 months ago

@allendav
16 months ago

#3 @allendav
16 months ago

To test:

  • Install this patch
  • Install and activate another plugin that exports personal data at higher than default (10) priority, e.g. WooCommerce or https://github.com/allendav/wp-privacy-test-plugin
  • Capture some personal data, start a new request, start export
  • Make sure User group appears near the top of the report, e.g. right after the About group

#4 @allendav
16 months ago

  • Keywords needs-testing added; needs-patch removed

#5 follow-up: @ianbelanger
16 months ago

@allendav Just tested this patch with your plugin and the User group does appear just below the About group

#6 in reply to: ↑ 5 @allendav
16 months ago

Replying to ianbelanger:

@allendav Just tested this patch with your plugin and the User group does appear just below the About group

Thank you!

#7 @allendav
16 months ago

  • Keywords has-patch added

#8 @desrosj
16 months ago

  • Keywords commit added; needs-testing removed

Looks good. Not sure that the inline comment is needed. The commit will describe the issue in detail, but using a priority of 0 is a pretty common and accepted core approach to place hooks at the beginning of the list. I've updated a patch without the comment so the committer can choose.

@desrosj
16 months ago

This ticket was mentioned in Slack in #gdpr-compliance by allendav. View the logs.


16 months ago

#10 @azaozz
16 months ago

In 43195:

Privacy: increase filter priority of the User group in Personal Data Exports.

Props allendav desrosj.
See #43966.

#11 @azaozz
16 months ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 43196:

Privacy: increase filter priority of the User group in Personal Data Exports.

Props allendav desrosj.
Merges [43195] to the 4.9 branch.
Fixes #43966.

#12 @desrosj
15 months ago

  • Component changed from General to Privacy

Moving to the new Privacy component.

Note: See TracTickets for help on using tickets.