WordPress.org

Make WordPress Core

Opened 3 weeks ago

Closed 13 days ago

Last modified 7 days ago

#43970 closed defect (bug) (fixed)

Add request type to the confirmation confirmation page - GDPR

Reported by: garrett-eclipse Owned by: desrosj
Milestone: 4.9.6 Priority: normal
Severity: normal Version: trunk
Component: Privacy Keywords: gdpr has-patch commit
Focuses: administration Cc:

Description

Hello,

When you click the link to confirm either of the request actions the page is pretty well the same in both cases can they have the request type there so you know what you confirmed at a glance.

Screen coming.

Can probably be as simple as 'Remove Personal Data Confirmation Action has been confirmed'

Thanks

Attachments (4)

Screen Shot 2018-05-04 at 1.30.51 PM.png (29.2 KB) - added by garrett-eclipse 3 weeks ago.
Action has been confirmed
43970.diff (804 bytes) - added by desrosj 2 weeks ago.
43970.2.diff (4.0 KB) - added by desrosj 13 days ago.
Screen Shot 2018-05-10 at 1.51.30 PM.png (90.8 KB) - added by desrosj 13 days ago.

Download all attachments as: .zip

Change History (27)

@garrett-eclipse
3 weeks ago

Action has been confirmed

#1 @xkon
3 weeks ago

  • Keywords gdpr added

#2 @desrosj
3 weeks ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.9.6

This ticket was mentioned in Slack in #core by desrosj. View the logs.


2 weeks ago

#4 @desrosj
2 weeks ago

  • Type changed from enhancement to defect (bug)

@desrosj
2 weeks ago

#5 @desrosj
2 weeks ago

  • Keywords has-patch commit added; needs-patch removed

In 43970.diff:

  • Change the notice to read "Action confirmed: Action Name".
  • Bolds "Action confirmed:"

This uses wp_user_request_action_description(), which does have a default return value that would not make sense in this context, but that condition will never occur because of the in_array() check using _wp_privacy_action_request_types() (which will only return the core export and erase action names.

If _wp_privacy_action_request_types() is made filterable in the future (or an alternative way to introduce privacy action request types is introduced), then the strings in wp_user_request_action_description() may need to be adjusted.

This ticket was mentioned in Slack in #gdpr-compliance by allendav. View the logs.


2 weeks ago

This ticket was mentioned in Slack in #gdpr-compliance by desrosj. View the logs.


2 weeks ago

#8 @pbarthmaier
2 weeks ago

Successful testing the action getting displayed in confirmation notice

[Image(https://monosnap.com/file/BN0zArjFlEedPbVYJX14LYqnX4DVjE)]

This ticket was mentioned in Slack in #core by desrosj. View the logs.


13 days ago

#10 @desrosj
13 days ago

  • Keywords needs-refresh added; commit removed
  • Owner set to desrosj
  • Status changed from new to assigned

The text for this should be updated to reflect the new suggestions in #44029.

#11 @desrosj
13 days ago

#44029 was marked as a duplicate.

@desrosj
13 days ago

#12 @desrosj
13 days ago

  • Keywords needs-testing added; needs-refresh removed

43970.2.diff has a small handful of improvements.

  • Updates the confirmation notices to match the suggestions on #44029
  • Move the user_request_action_confirmed_message filter into the _wp_privacy_account_request_confirmed_message() function. The function was filtering the exact same text in the wp-login.php file, so was somewhat superfluous. The filter should still exist, though.
  • Added an inline docblock for the user_request_action_confirmed_message filter.
  • Added missing parameter documentation in the _wp_privacy_account_request_confirmed_message() function.

@melchoyce I used the same green color that the admin uses for success messages. It seemed a big darker than in your mockup from #44029, though. Please check that you are ok with this color, or just send me a different hex value.

This ticket was mentioned in Slack in #gdpr-compliance by desrosj. View the logs.


13 days ago

#14 @desrosj
13 days ago

  • Keywords needs-testing removed

Also, 43970.2.diff is dependent on #43973 landing.

#15 follow-up: @melchoyce
13 days ago

I used the same green color that the admin uses for success messages. It seemed a big darker than in your mockup from #44029, though. Please check that you are ok with this color, or just send me a different hex value.

@desrosj Can you post a screenshot?

#16 in reply to: ↑ 15 @melchoyce
13 days ago

Replying to melchoyce:

I used the same green color that the admin uses for success messages. It seemed a big darker than in your mockup from #44029, though. Please check that you are ok with this color, or just send me a different hex value.

@desrosj Can you post a screenshot?

(FWIW — core patterns always come first. I'm sure what you're using is correct, I just want to be able to compare for my own reference.)

#17 @desrosj
13 days ago

Actually, putting them side by side, they do look the same now.

#18 @melchoyce
13 days ago

Yeah, I think the color difference might be a monitor/screen thing.

#19 @desrosj
13 days ago

  • Keywords commit added

Marking commit pending #43973.

#20 @allendav
13 days ago

Tests well. No comments on code. Ship it.

#21 @SergeyBiryukov
13 days ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43232:

Privacy: Update request confirmation notice text for clarity.

Props desrosj, melchoyce, garrett-eclipse.
Fixes #43970.

#22 @SergeyBiryukov
13 days ago

In 43233:

Privacy: Update request confirmation notice text for clarity.

Props desrosj, melchoyce, garrett-eclipse.
Merges [43232] to the 4.9 branch.
Fixes #43970.

#23 @desrosj
7 days ago

  • Component changed from General to Privacy

Moving to the new Privacy component.

Note: See TracTickets for help on using tickets.