Add request type to the confirmation confirmation page - GDPR

[garrett-eclipse]

Hello,

When you click the link to confirm either of the request actions the page is pretty well the same in both cases can they have the request type there so you know what you confirmed at a glance.

Screen coming.

Can probably be as simple as 'Remove Personal Data Confirmation Action has been confirmed'

Thanks

[garrett-eclipse]

Action has been confirmed

[desrosj]

In 43970.diff​:

• Change the notice to read "Action confirmed: Action Name".
• Bolds "Action confirmed:"

This uses wp_user_request_action_description(), which does have a default return value that would not make sense in this context, but that condition will never occur because of the in_array() check using _wp_privacy_action_request_types() (which will only return the core export and erase action names.

If _wp_privacy_action_request_types() is made filterable in the future (or an alternative way to introduce privacy action request types is introduced), then the strings in wp_user_request_action_description() may need to be adjusted.

[pbarthmaier]

Successful testing the action getting displayed in confirmation notice

[Image(​https://monosnap.com/file/BN0zArjFlEedPbVYJX14LYqnX4DVjE)]

[desrosj]

The text for this should be updated to reflect the new suggestions in #44029.

[desrosj]

#44029 was marked as a duplicate.

[desrosj]

43970.2.diff​ has a small handful of improvements.

• Updates the confirmation notices to match the suggestions on #44029
• Move the user_request_action_confirmed_message filter into the _wp_privacy_account_request_confirmed_message() function. The function was filtering the exact same text in the wp-login.php file, so was somewhat superfluous. The filter should still exist, though.
• Added an inline docblock for the user_request_action_confirmed_message filter.
• Added missing parameter documentation in the _wp_privacy_account_request_confirmed_message() function.

@melchoyce I used the same green color that the admin uses for success messages. It seemed a big darker than in your mockup from #44029, though. Please check that you are ok with this color, or just send me a different hex value.

[desrosj]

Also, 43970.2.diff​ is dependent on #43973 landing.

[melchoyce]

I used the same green color that the admin uses for success messages. It seemed a big darker than in your mockup from #44029, though. Please check that you are ok with this color, or just send me a different hex value.

@desrosj Can you post a screenshot?

[melchoyce]

Replying to melchoyce:

I used the same green color that the admin uses for success messages. It seemed a big darker than in your mockup from #44029, though. Please check that you are ok with this color, or just send me a different hex value.

@desrosj Can you post a screenshot?

(FWIW — core patterns always come first. I'm sure what you're using is correct, I just want to be able to compare for my own reference.)

[desrosj]

Actually, putting them side by side, they do look the same now.

[melchoyce]

Yeah, I think the color difference might be a monitor/screen thing.

[desrosj]

Marking commit pending #43973.

[allendav]

Tests well. No comments on code. Ship it.

[SergeyBiryukov]

In 43232:

Privacy: Update request confirmation notice text for clarity.

Props desrosj, melchoyce, garrett-eclipse.
Fixes #43970.

[SergeyBiryukov]

In 43233:

Privacy: Update request confirmation notice text for clarity.

Props desrosj, melchoyce, garrett-eclipse.
Merges [43232] to the 4.9 branch.
Fixes #43970.

[desrosj]

Moving to the new Privacy component.