WordPress.org

Make WordPress Core

Opened 14 months ago

Last modified 7 days ago

#43974 new defect (bug)

Both personal data request processes should follow the same convention

Reported by: garrett-eclipse Owned by:
Milestone: 5.3 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: needs-patch good-first-bug
Focuses: administration Cc:

Description

Hello,

I noticed with the GDPR requests process that the export requests workflow only affects the Next Steps buttons, while the removal request instead injects an alert. Can the two processes be consistent?

Button Flow for Sending Email;
https://gyazo.com/241ea304afd342419b585697aa4ac9a3

Button Flow for Removing Data;
https://gyazo.com/3b72b3622b3e38b1c9868f8971eb6ee7

Was thinking the button should go away with 'Data Removed' or something.

But that being said I do like the alert as it does give more info if data was already removed but maybe not in the table and instead in the standard wp alert location. And maybe have an alert for the email send.

Thanks

Attachments (1)

Screen Shot 2018-05-04 at 1.32.43 PM.png (51.7 KB) - added by garrett-eclipse 14 months ago.
Alert Injected

Download all attachments as: .zip

Change History (13)

#1 @xkon
14 months ago

  • Keywords gdpr added

#2 @desrosj
13 months ago

  • Component changed from General to Privacy

Moving to the new Privacy component.

#3 @desrosj
13 months ago

  • Version changed from trunk to 4.9.6

Marking Privacy change as introduced in 4.9.6.

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


13 months ago

#5 @desrosj
13 months ago

  • Keywords ui-feedback added
  • Milestone changed from Awaiting Review to Future Release

#6 @desrosj
12 months ago

  • Summary changed from Both request processes should follow the same convention - GDPR to Both personal data request processes should follow the same convention

#7 @desrosj
12 months ago

  • Keywords gdpr removed

Removing the GDPR keyword. This has been replaced by the new Privacy component and privacy focuses in Trac.

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


3 weeks ago

#9 @kjellr
3 weeks ago

  • Keywords ui-feedback removed

👋 We discussed this ticket in the weekly #design triage chat:
https://wordpress.slack.com/archives/C02S78ZAL/p1558975417034500

These two messages do seem like they should be consistent. Since "No personal data found for this user" is likely too long to include in place of the button, I suggest we use the alert-style treatment in both places. Also, in both cases, the button should disappear when the alert is visible, since re-pressing should have no real effect.

Thanks!

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


2 weeks ago

#11 @garrett-eclipse
2 weeks ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Future Release to 5.3

Thanks @kjellr and #design for the review. Now that we have some direction going to move into 5.3 and label good-first-bug for wceu contributor day.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


7 days ago

Note: See TracTickets for help on using tickets.