WordPress.org

Make WordPress Core

Opened 16 months ago

Last modified 4 weeks ago

#43974 new defect (bug)

Both personal data request processes should follow the same convention

Reported by: garrett-eclipse Owned by:
Milestone: 5.3 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-patch needs-testing needs-copy-review
Focuses: administration Cc:

Description

Hello,

I noticed with the GDPR requests process that the export requests workflow only affects the Next Steps buttons, while the removal request instead injects an alert. Can the two processes be consistent?

Button Flow for Sending Email;
https://gyazo.com/241ea304afd342419b585697aa4ac9a3

Button Flow for Removing Data;
https://gyazo.com/3b72b3622b3e38b1c9868f8971eb6ee7

Was thinking the button should go away with 'Data Removed' or something.

But that being said I do like the alert as it does give more info if data was already removed but maybe not in the table and instead in the standard wp alert location. And maybe have an alert for the email send.

Thanks

Attachments (5)

Screen Shot 2018-05-04 at 1.32.43 PM.png (51.7 KB) - added by garrett-eclipse 16 months ago.
Alert Injected
43974.diff (2.7 KB) - added by Kerfred 2 months ago.
Screen Shot 2019-06-21 at 11.07.24 PM.png (461.5 KB) - added by garrett-eclipse 2 months ago.
Testing results for the patch, works nicely and is now consistent.
43974.2.diff (2.8 KB) - added by garrett-eclipse 2 months ago.
Minor tweak to 'Email sent' verbiage as there's now more space available have expanded on verbiage to make it clear
43974.3.diff (2.7 KB) - added by garrett-eclipse 7 weeks ago.
Updated Verbiage

Download all attachments as: .zip

Change History (27)

#1 @xkon
16 months ago

  • Keywords gdpr added

#2 @desrosj
15 months ago

  • Component changed from General to Privacy

Moving to the new Privacy component.

#3 @desrosj
15 months ago

  • Version changed from trunk to 4.9.6

Marking Privacy change as introduced in 4.9.6.

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


15 months ago

#5 @desrosj
15 months ago

  • Keywords ui-feedback added
  • Milestone changed from Awaiting Review to Future Release

#6 @desrosj
14 months ago

  • Summary changed from Both request processes should follow the same convention - GDPR to Both personal data request processes should follow the same convention

#7 @desrosj
14 months ago

  • Keywords gdpr removed

Removing the GDPR keyword. This has been replaced by the new Privacy component and privacy focuses in Trac.

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


3 months ago

#9 @kjellr
3 months ago

  • Keywords ui-feedback removed

👋 We discussed this ticket in the weekly #design triage chat:
https://wordpress.slack.com/archives/C02S78ZAL/p1558975417034500

These two messages do seem like they should be consistent. Since "No personal data found for this user" is likely too long to include in place of the button, I suggest we use the alert-style treatment in both places. Also, in both cases, the button should disappear when the alert is visible, since re-pressing should have no real effect.

Thanks!

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


3 months ago

#11 @garrett-eclipse
3 months ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Future Release to 5.3

Thanks @kjellr and #design for the review. Now that we have some direction going to move into 5.3 and label good-first-bug for wceu contributor day.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


2 months ago

This ticket was mentioned in Slack in #core-privacy by postphotos. View the logs.


2 months ago

#14 @Kerfred
2 months ago

I'm working on it.

@Kerfred
2 months ago

#15 @Kerfred
2 months ago

  • Keywords has-patch added; needs-patch removed

I have hidden the "Erase" button upon success.
And I have applied the same style for the "Export" action.

This ticket was mentioned in Slack in #core-php by kerfred. View the logs.


2 months ago

@garrett-eclipse
2 months ago

Testing results for the patch, works nicely and is now consistent.

@garrett-eclipse
2 months ago

Minor tweak to 'Email sent' verbiage as there's now more space available have expanded on verbiage to make it clear

#17 @garrett-eclipse
2 months ago

  • Keywords needs-testing needs-copy-review added; good-first-bug removed

Thanks @Kerfred I appreciate the contribution.

Testing went successfully, see screenshot.

I'm adding needs-copy-review as I feel we can provide more context in the message now that there's more space available for 'Email sent'.

My initial thought on verbiage would be;
'The personal data exported for this user was sent successfully.'

I've put this in 43974.2.diff and will wait on some copy feedback before we move this forward.

All the best

#18 @birgire
2 months ago

I'm adding needs-copy-review as I feel we can provide more context in the message now that there's more
space available for 'Email sent'.

Good suggestion @garrett-eclipse

My initial thought on verbiage would be;
'The personal data exported for this user was sent successfully.'

This sounds good and I think this an improvement to the current "Email sent.".

I would suggest a minor change, to reflect the text changes from #44822

were we changed the "Email Data" text to "Send Export Link".

Perhaps:

'The export link for this user was sent successfully.'

or

'The export link was successfully sent to this user.'

My first thought was to add "link" to your suggestion, but I'm not so sure about the long phrase: "personal data export link" :-) But there might be ways to rearrange it, to avoid such cases, e.g. with: "The link to the personal data export was successfully sent to this user." or something similar.

#19 @garrett-eclipse
8 weeks ago

Thanks @birgire I appreciate the feedback and good point on it being an export link.

For options I'm looking at;

  1. "The link to the personal data export was successfully sent to this user."
  2. "The link to the personal data export was successfully sent."
  3. "The personal data export link was successfully sent."

I'm leaning towards #2 but #3 is a bit more concise and defines it as 'personal data export link' which is what is is, not sure if that's too much of a mouthful or hard to translate.

Going to see if @marybaum could take a look.

#20 @marybaum
8 weeks ago

Thanks @birgire I appreciate the feedback and good point on it being an export link.
For options I'm looking at;
"The link to the personal data export was successfully sent to this user."
"The link to the personal data export was successfully sent."
"The personal data export link was successfully sent."

Welp. How about

"Success! Personal data export link sent to mailto:user@domain.com."

Slightly less redundant and more energetic than 'was-successfully-sent' and gives user a look at the email address the data went to -- or swear under their breath and try again with another.

If this were copy instead of a string, I'd be advocating for 'the link has gone to' or some more active construction, but in a string that's of course getting too far ahead of ourselves in the process.

@garrett-eclipse
7 weeks ago

Updated Verbiage

#21 @garrett-eclipse
7 weeks ago

Thanks @marybaum I appreciate the feedback.

Sadly the email isn't readily available at the time of the string construction as it's localized before the javascript is loaded and then used in response to the email action. The email could be appended to the end in the javascript but this would break RTL language localizations.

I also see what you're saying with the 'Success!' being more energetic but am wondering if that's needed as it's already in a success notice. We could even do without the word completely.

The other strings we're trying to be consistent with here use 'the personal data' and 'for this user' such as the relevant one we're trying to match for Erasure;
'foundAndRemoved' => __( 'All of the personal data found for this user was erased.' ),

With that in mind I've added 43974.3.diff which goes with;
'emailSent' => __( 'The personal data export link for this user was sent.' ),
*By saying 'sent' it already indicates success, that and it's in a success notice.

Appreciate your thoughts @birgire / @marybaum / @Kerfred

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


4 weeks ago

Note: See TracTickets for help on using tickets.