Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#4398 closed enhancement (fixed)

Prune options table

Reported by: ryan Owned by: Nazgul
Milestone: 2.3 Priority: normal
Severity: normal Version: 2.3
Component: Administration Keywords: has-patch commit
Focuses: Cc:


option_can_override, option_type, option_width, option_height, option_description, and option_admin_level are all unused and should be removed from the schema.

Attachments (2)

4398.diff (4.0 KB) - added by Nazgul 11 years ago.
4398.002.diff (4.6 KB) - added by markjaquith 11 years ago.

Download all attachments as: .zip

Change History (11)

#1 @rob1n
11 years ago

Can we do this without breaking plugins? I remember this came up a while back but people mentioned that plugins used those unused fields for their own values.

#2 @ryan
11 years ago

Looking through the plugin repository, I see option_description used here and there. Maybe we can keep that one, although I'd rather just axe it and the others and get plugins to use the API that has been around for years. Doing direct queries circumvents the cache. Anyhow, we're already busting plugins in 2.3 with the taxonomy schema changes. Let's bust some more. :-)

#3 @rob1n
11 years ago

+1 then. Survival of the fittest plugin ;).

#4 @markjaquith
11 years ago

Axe 'em.

11 years ago

#5 @Nazgul
11 years ago

  • Keywords has-patch added
  • Owner changed from anonymous to Nazgul
  • Status changed from new to assigned
  • Type changed from defect to enhancement

#6 @markjaquith
11 years ago

Nazgul, your patch neglected to remove the columns from the schema, so they'd be re-created on the next upgrade! :-) Try 002 on for size.

#7 @Nazgul
11 years ago

Mark, thanks for the new patch!

I'd removed them in my source, but for some reason that didn't make it into my patch. Weird.

#8 @Nazgul
11 years ago

  • Keywords commit added

#9 @markjaquith
11 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed
  • Version set to 2.3

(In [6039]) Deprecate option_can_override, option_type, option_width, option_height, option_description, option_admin_level from options table. Props Nazgul. fixes #4398

Note: See TracTickets for help on using tickets.