WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #43992, comment 45


Ignore:
Timestamp:
03/21/2019 06:48:49 PM (18 months ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #43992, comment 45

    initial v1  
    1 * I'd like to see specific error messages for not meeting minimum WP version requirement vs. PHP version, rather then "WordPress and/or PHP". `validate_plugin_requirements()` could return `WP_Error` on error, I agree with @TimothyBlynJacobs in comment:33 here. That can probably be adjusted after beta though.
     1* I'd like to see specific error messages for not meeting minimum WP version requirement vs. PHP version, rather than "WordPress and/or PHP". `validate_plugin_requirements()` could return `WP_Error` on error, I agree with @TimothyBlynJacobs in comment:33 here. That can probably be adjusted after beta though.
    22* Introducing `wp_is_*_compatible()` wrappers doesn't seem to bring a huge benefit at a glance, as there are only two or three of these checks in core. Maybe it will be easier to see once the other instances are updated to use the wrappers. I agree they should be prefixed with `wp_`, just in case.
    33