WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 5 months ago

Last modified 2 months ago

#43994 closed enhancement (fixed)

Help for Export/Erasure and Privacy admin pages need text and links.

Reported by: xkon Owned by: xkon
Milestone: 5.7 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-screenshots has-patch needs-copy-review commit
Focuses: administration, ui-copy Cc:

Description

Both of the new Tools don't have any Help tab at all at the moment so that needs to get added and the Privacy (settings) page has a somewhat of abstracted text but nothing specific with a link that points to # since there are no online docs yet.

I think we have 2 options to make it to the release in a nice way:

1] We remove the Help tab from the Privacy(settings) as well.

2] We have to add Help everywhere with the appropriate explanations and links to online docs for people to read more if they want.

Any extra suggestions or texts that we could add?

Attachments (8)

posts-help-overview.png (69.3 KB) - added by desrosj 3 years ago.
post-help-bulk-actions.png (92.2 KB) - added by desrosj 3 years ago.
posts-help-available-actions.png (113.4 KB) - added by desrosj 3 years ago.
posts-help-screen-content.png (124.4 KB) - added by desrosj 3 years ago.
43994.diff (8.5 KB) - added by xkon 5 months ago.
erase_help.jpg (150.5 KB) - added by xkon 5 months ago.
export_help.jpg (145.4 KB) - added by xkon 5 months ago.
43994-before-after.gif (4.1 MB) - added by hellofromTonya 5 months ago.
Before and after applying 43994.diff patch. Works as expected.

Change History (50)

This ticket was mentioned in Slack in #gdpr-compliance by xkon. View the logs.


3 years ago

This ticket was mentioned in Slack in #gdpr-compliance by desrosj. View the logs.


3 years ago

#3 @desrosj
3 years ago

  • Milestone changed from 4.9.6 to 4.9.7

Bumping to 4.9.7 so enough thought can be put into providing helpful text.

#4 @desrosj
3 years ago

  • Component changed from General to Privacy

Moving to the new Privacy component.

#5 @netweblogic
3 years ago

We definitely need to mention what gets deleted/exported and what does not (whether on .org or inline). After working on some integration of my own plugins, I'm noticing not much information is given about what gets deleted and what does not (e.g. user posts and author info) and the only way to understanding it is trying it out yourself.

For example, currently, posts submitted by authors are not exported or erased. Comments and user accounts are not erased either, the comment is just anonymized and the user account remains. I appreciate what exactly is removed/deleted is changed down the line.

Additionally, like the privacy policy, it may be helpful for other plugins to also have a way to hook into this help and state what they delete/anonymize too, possibly deriving from a list generated by WP containing things it deletes/anonymizes/keeps.

Last edited 3 years ago by netweblogic (previous) (diff)

#6 @desrosj
3 years ago

  • Milestone changed from 4.9.7 to 4.9.8

Moving all tickets in 4.9.7 to 4.9.8.

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


3 years ago

#8 @desrosj
3 years ago

  • Keywords needs-patch added; gdpr removed

#9 @desrosj
3 years ago

  • Type changed from defect (bug) to enhancement

This ticket was mentioned in Slack in #core by joshuawold. View the logs.


3 years ago

#11 @desrosj
3 years ago

  • Milestone changed from 4.9.8 to 4.9.9

4.9.8 RC is out. Punting to 4.9.9.

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


3 years ago

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


3 years ago

#14 @desrosj
3 years ago

  • Keywords has-screenshots added

Added some screenshots of what the Posts page has. I think some of these tabs might actually work for us.

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


3 years ago

#16 @idea15
3 years ago

  • Owner set to idea15
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


3 years ago

#18 @desrosj
3 years ago

  • Milestone changed from 4.9.9 to 5.0

Punting to 5.0 since it falls outside of the 4.9.9 focus.

#19 @pento
3 years ago

  • Milestone changed from 5.0 to 5.1

#20 @desrosj
2 years ago

  • Milestone changed from 5.1 to Future Release

This still needs copy. Punting until some is written.

#21 @garrett-eclipse
21 months ago

#48243 was marked as a duplicate.

This ticket was mentioned in Slack in #core-privacy by burtrw. View the logs.


13 months ago

This ticket was mentioned in PR #315 on WordPress/wordpress-develop by burtrw.


13 months ago

  • Keywords has-patch added; needs-patch removed

#25 @burtrw
13 months ago

Soo, I admit, I got lost in trying SVN and I'm a total novice with pull requests, etc. But I did test this locally and added a combination of some text at the top of the screen and text for the "Help" tab. I tried to follow examples from other core pages and re-use some of the info in docs.

I also couldn't figure out how to do both files in one PR, so sorry about that. Grr.

Last edited 13 months ago by burtrw (previous) (diff)

#26 @garrett-eclipse
13 months ago

  • Focuses administration ui-copy added
  • Milestone changed from Future Release to 5.5
  • Owner changed from idea15 to garrett-eclipse
  • Status changed from assigned to reviewing
  • Version set to 4.9.6

Thanks @burtrw this is a great start, I've moved this to review for 5.5.

#28 @burtrw
13 months ago

I re-did the PRs to combine them into one. I also moved some of my suggested text from the into area of the screens to the Help tab to better match tone, length, and type of text on other core screens.

This ticket was mentioned in Slack in #core-privacy by burtrw. View the logs.


13 months ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


12 months ago

#31 @davidbaumwald
12 months ago

@garrett-eclipse Is this still doable with 5.5 Beta 1 landing in a few days?

#32 @davidbaumwald
12 months ago

  • Milestone changed from 5.5 to Future Release

With Beta 1 landing tomorrow, this ticket is being moved to Future Release. If any maintainer or committer feels the remainder of this ticket can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

@xkon
5 months ago

@xkon
5 months ago

@xkon
5 months ago

#33 @xkon
5 months ago

  • Keywords needs-copy-review needs-testing added
  • Milestone changed from Future Release to 5.7
  • Owner changed from garrett-eclipse to xkon

Thanks for all the work here @burtrw !

43994.diff is a refresh of the latest PR to apply cleanly.

This has been waiting for quite a while and it would be nice to finally have some help tabs in 5.7 so I'm marking it just in case it can make it.

The text looks good to me and I've also made a small change to add some sprintf so we can correctly use the admin_url() where needed.

Also adding a needs-testing & needs-copy-review for a second look on the text as well just in case something isn't fully clear from the information provided :).

To test:

  • Apply the 43994.diff patch.
  • Navigate to your wp-admin and from the menu select Tools, Export Personal Data & Erase Personal Data
  • You should now have a Help button (top right of the screen along with screen options) available for these screens. Preview at export_help.jpg & erase_help.jpg

@hellofromTonya
5 months ago

Before and after applying 43994.diff patch. Works as expected.

#34 @hellofromTonya
5 months ago

  • Keywords commit added; needs-testing removed

After applying the latest patch, works as expected. Removing needs-testing. Adding commit.

#35 @desrosj
5 months ago

  • Owner changed from xkon to desrosj

#36 @desrosj
5 months ago

  • Owner changed from desrosj to xkon

#37 @SergeyBiryukov
5 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 50147:

Privacy: Add help tabs for Export Personal Data and Erase Personal Data screens.

Props xkon, burtrw, netweblogic, desrosj, hellofromTonya, garrett-eclipse.
Fixes #43994.

Note: See TracTickets for help on using tickets.