WordPress.org

Make WordPress Core

Opened 18 months ago

Last modified 5 months ago

#43999 new enhancement

Twenty Seventeen: Add Telegram and Whatsapp support to Social Media Menu

Reported by: cpasqualini Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 5.1
Component: Bundled Theme Keywords: has-patch has-screenshots needs-design-feedback
Focuses: Cc:
PR Number:

Description

I have at least two clients requesting links to Whatsapp and Telegram.
The icons I made are "Ugly", so it would be preferable to have a better SVG design for the icons.

thanks!

Attachments (3)

Add-Telegram-and-Whatsapp-to-Social-Media-Menu.patch (4.3 KB) - added by cpasqualini 18 months ago.
Add Telegram and Whatsapp to social media menu
43999.2.diff (4.2 KB) - added by audrasjb 15 months ago.
Telegram & Whatsapp: correct order in twentyseventeen_social_links_icons() function
social-icons-telegram-whatsapp.png (14.1 KB) - added by audrasjb 15 months ago.
Social Icons: Telegram & Whatsapp

Download all attachments as: .zip

Change History (14)

@cpasqualini
18 months ago

Add Telegram and Whatsapp to social media menu

This ticket was mentioned in Slack in #core by cpasqualini. View the logs.


16 months ago

@audrasjb
15 months ago

Telegram & Whatsapp: correct order in twentyseventeen_social_links_icons() function

#2 @audrasjb
15 months ago

  • Milestone changed from Awaiting Review to 5.0
  • Severity changed from trivial to normal
  • Type changed from feature request to enhancement

Hello @cpasqualini, welcome to WordPress Core Trac and thanks for your ticket.

I tested your patch and it works fine. Your SVG icons looks fine to me.

In 43999.2.diff I updated your patch to improve the position of the social link icons in twentyseventeen_social_links_icons() function.

Cheers,

Jb

@audrasjb
15 months ago

Social Icons: Telegram & Whatsapp

#3 @audrasjb
15 months ago

  • Keywords has-screenshots added

#4 @audrasjb
15 months ago

  • Milestone changed from 5.0 to 4.9.9

#5 @pento
13 months ago

  • Milestone changed from 4.9.9 to 5.0.1

#6 @pento
10 months ago

  • Milestone changed from 5.0.1 to 5.0.2

#7 @pento
10 months ago

  • Milestone changed from 5.0.2 to 5.0.3

#8 @audrasjb
10 months ago

  • Keywords ui-feedback added
  • Milestone changed from 5.0.3 to 5.1

5.0.3 is going to be released in a couple of weeks. We are currently sorting the remaining tickets in the milestone. It doesn't appear that ticket can be handled in the next couple of weeks (still needs review from component maintainers). Let's add ui-feedback tag and address that in 5.1 which is coming in February. Feel free to change/ask to change the milestone if you think the issue can be quickly resolved.

#9 @laurelfulford
10 months ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Add Telegram and Whatsapp support to Social Media Menu to Twenty Seventeen: Add Telegram and Whatsapp support to Social Media Menu

#10 @laurelfulford
10 months ago

  • Milestone changed from 5.1 to Future Release

Thanks @cpasqualini and @audrasjb!

I'm going to move this one to 'Future Release' for now -- we've had a couple back-to-back theme updates for Twenty Seventeen with adding the block editor support, and it would be good to get a larger set of changes queued up and ready to go before the next one :)

#11 @karmatosed
5 months ago

  • Keywords needs-design-feedback added; needs-design ui-feedback removed

I think this has design so I am going to tidy up that keyword and make sure this has feedback one.

Note: See TracTickets for help on using tickets.