WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 6 months ago

#43999 closed enhancement (fixed)

Twenty Seventeen: Add Telegram and Whatsapp support to Social Media Menu

Reported by: cpasqualini Owned by: ianbelanger
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-screenshots
Focuses: Cc:

Description

I have at least two clients requesting links to Whatsapp and Telegram.
The icons I made are "Ugly", so it would be preferable to have a better SVG design for the icons.

thanks!

Attachments (5)

Add-Telegram-and-Whatsapp-to-Social-Media-Menu.patch (4.3 KB) - added by cpasqualini 3 years ago.
Add Telegram and Whatsapp to social media menu
43999.2.diff (4.2 KB) - added by audrasjb 2 years ago.
Telegram & Whatsapp: correct order in twentyseventeen_social_links_icons() function
social-icons-telegram-whatsapp.png (14.1 KB) - added by audrasjb 2 years ago.
Social Icons: Telegram & Whatsapp
43999.3.diff (4.3 KB) - added by ibdz 8 months ago.
Add Telegram & Whatsapp: correct SVG icon size
social-icons-43999.3.png (6.5 KB) - added by ibdz 8 months ago.

Download all attachments as: .zip

Change History (22)

@cpasqualini
3 years ago

Add Telegram and Whatsapp to social media menu

This ticket was mentioned in Slack in #core by cpasqualini. View the logs.


2 years ago

@audrasjb
2 years ago

Telegram & Whatsapp: correct order in twentyseventeen_social_links_icons() function

#2 @audrasjb
2 years ago

  • Milestone changed from Awaiting Review to 5.0
  • Severity changed from trivial to normal
  • Type changed from feature request to enhancement

Hello @cpasqualini, welcome to WordPress Core Trac and thanks for your ticket.

I tested your patch and it works fine. Your SVG icons looks fine to me.

In 43999.2.diff I updated your patch to improve the position of the social link icons in twentyseventeen_social_links_icons() function.

Cheers,

Jb

@audrasjb
2 years ago

Social Icons: Telegram & Whatsapp

#3 @audrasjb
2 years ago

  • Keywords has-screenshots added

#4 @audrasjb
2 years ago

  • Milestone changed from 5.0 to 4.9.9

#5 @pento
2 years ago

  • Milestone changed from 4.9.9 to 5.0.1

#6 @pento
2 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#7 @pento
2 years ago

  • Milestone changed from 5.0.2 to 5.0.3

#8 @audrasjb
2 years ago

  • Keywords ui-feedback added
  • Milestone changed from 5.0.3 to 5.1

5.0.3 is going to be released in a couple of weeks. We are currently sorting the remaining tickets in the milestone. It doesn't appear that ticket can be handled in the next couple of weeks (still needs review from component maintainers). Let's add ui-feedback tag and address that in 5.1 which is coming in February. Feel free to change/ask to change the milestone if you think the issue can be quickly resolved.

#9 @laurelfulford
23 months ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Add Telegram and Whatsapp support to Social Media Menu to Twenty Seventeen: Add Telegram and Whatsapp support to Social Media Menu

#10 @laurelfulford
23 months ago

  • Milestone changed from 5.1 to Future Release

Thanks @cpasqualini and @audrasjb!

I'm going to move this one to 'Future Release' for now -- we've had a couple back-to-back theme updates for Twenty Seventeen with adding the block editor support, and it would be good to get a larger set of changes queued up and ready to go before the next one :)

#11 @karmatosed
19 months ago

  • Keywords needs-design-feedback added; needs-design ui-feedback removed

I think this has design so I am going to tidy up that keyword and make sure this has feedback one.

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


12 months ago

#13 @ibdz
12 months ago

At #design triage today, we noticed that the size of Telegram icon is not consistent with other icons (too small).

#14 @ibdz
12 months ago

I want to suggest using this svg icon for Telegram instead:

<symbol id="icon-telegram" viewBox="0 0 32 32">
<path class="path1" d="M30.8,2.2L0.6,13.9c-0.8,0.3-0.7,1.3,0,1.6l7.4,2.8l2.9,9.2c0.2,0.6,0.9,0.8,1.4,0.4l4.1-3.4 c0.4-0.4,1-0.4,1.5,0l7.4,5.4c0.5,0.4,1.2,0.1,1.4-0.5L32,3.2C32.1,2.5,31.4,1.9,30.8,2.2z M25,8.3l-11.9,11 c-0.4,0.4-0.7,0.9-0.8,1.5l-0.4,3c-0.1,0.4-0.6,0.4-0.7,0.1l-1.6-5.5c-0.2-0.6,0.1-1.3,0.6-1.6l14.4-8.9C25,7.7,25.3,8.1,25,8.3z"/>
</symbol>

#15 @ianbelanger
9 months ago

  • Keywords needs-refresh added; needs-design-feedback removed
  • Milestone changed from Future Release to 5.5
  • Version 5.1 deleted

@ibdz
8 months ago

Add Telegram & Whatsapp: correct SVG icon size

#16 @ianbelanger
6 months ago

  • Keywords needs-refresh removed
  • Owner set to ianbelanger
  • Status changed from new to reviewing

Reviewing for commit.

#17 @ianbelanger
6 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 48027:

Bundled Themes: Twenty Seventeen add Telegram and Whatsapp support to Social Media Menu.

Adds Telegram and Whatsapp support and SVG's to Social Media Menu.

Props cpasqualini, audrasjb, laurelfulford, karmatosed, ibdz.
Fixes #43999.

Note: See TracTickets for help on using tickets.