WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #44000, comment 4


Ignore:
Timestamp:
05/10/2018 03:44:53 PM (6 weeks ago)
Author:
birgire
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #44000, comment 4

    initial v1  
    11[attachment:44000.3.diff] takes a similar approach as #43954 (43954.2.diff) and adds the ''Tools'' bubble directly into the {{{wp-admin/menu.php}}} file, instead of using a filter. It also re-uses the {{{.plugin-count}}} and {{{.plugin-updates}}} CSS classes as well.
    22
    3 I think we can't add the submenus directly to the {{{wp-admin/menu.php}}} file as well, because we don't have specific submenu files, to use the in the {{{$submenu['tools.php']}}} array. So we could look further into what's the best way to add bubbles to the submenus here.
     3I don't think we can add the submenus directly to the {{{wp-admin/menu.php}}} file as well, because we don't have specific submenu files, to use the in the {{{$submenu['tools.php']}}} array. So we could look further into what's the best way to add bubbles to the submenus here.
    44
    55ps: We array cast the counting object, in [attachment:44000.2.diff] and [attachment:44000.3.diff], since it seems problematic to do {{{$obj->request-confirmed}}} with a dash in the property name.