WordPress.org

Make WordPress Core

Opened 7 weeks ago

Last modified 7 days ago

#44006 reviewing enhancement

Privacy Policy page should have suffix like other special pages

Reported by: danieltj Owned by: desrosj
Milestone: 4.9.7 Priority: normal
Severity: minor Version: 4.9.6
Component: Privacy Keywords: has-screenshots gdpr has-patch
Focuses: administration Cc:

Description

The Privacy Policy page (when set in the Privacy page within Tools > Privacy) doesn't have the special page suffix like the Home and Blog pages do. As this page has special options when officially set as The Privacy Policy Page, it needs to have a suffix so people can pick it out easily from the list of pages.

Attachments (6)

privacy-policy.png (78.8 KB) - added by danieltj 7 weeks ago.
Privacy Policy page without the special page suffix
44006.diff (632 bytes) - added by subrataemfluence 7 weeks ago.
src/wp-admin/includes/template.php
privacy-polity-with-suffix.png (5.1 KB) - added by subrataemfluence 7 weeks ago.
44006-2.diff (630 bytes) - added by subrataemfluence 7 weeks ago.
Suffix modified from 'Privacy Policy' to 'Privacy Page'.
44006.2.diff (570 bytes) - added by desrosj 3 weeks ago.
44006-privacy-policy-page-label.PNG (5.2 KB) - added by ianbelanger 3 weeks ago.
Privacy Policy page suffix

Download all attachments as: .zip

Change History (18)

@danieltj
7 weeks ago

Privacy Policy page without the special page suffix

#1 @danieltj
7 weeks ago

  • Keywords has-screenshots gdpr added

@subrataemfluence
7 weeks ago

src/wp-admin/includes/template.php

#2 @subrataemfluence
7 weeks ago

  • Keywords has-patch added; needs-patch removed

@subrataemfluence
7 weeks ago

Suffix modified from 'Privacy Policy' to 'Privacy Page'.

This ticket was mentioned in Slack in #gdpr-compliance by allendav. View the logs.


7 weeks ago

#4 @desrosj
6 weeks ago

  • Component changed from Posts, Post Types to Privacy

Moving to the new Privacy component.

#5 @ocean90
6 weeks ago

#44132 was marked as a duplicate.

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


3 weeks ago

#7 @desrosj
3 weeks ago

  • Owner set to desrosj
  • Status changed from new to reviewing

@desrosj
3 weeks ago

#8 @desrosj
3 weeks ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 4.9.7
  • Version changed from trunk to 4.9.6

This is a great idea.

44006.2.diff has a few minor improvements:

  • Remove the first conditional, it was superfluous because the second condition would always catch the first too.
  • Added some missing spaces to adhere to the coding standards.
  • Changed the text to Privacy Policy Page for consistency with the option name.

#9 @ianbelanger
3 weeks ago

  • Keywords needs-testing removed

Tested 44006.2.diff and the patch applies cleanly and works as intended. Screenshot coming.

@ianbelanger
3 weeks ago

Privacy Policy page suffix

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


7 days ago

#11 @desrosj
7 days ago

As discussed in today's Privacy component bug scrub, the text seems a bit repetitive when the page's name is "Privacy Policy". But not sure that there is anything we can do about this. The page title is not guaranteed to be "Privacy Policy" (a user could change it any time they want).

#12 @ianbelanger
7 days ago

Sorry, wrong ticket

Last edited 7 days ago by ianbelanger (previous) (diff)
Note: See TracTickets for help on using tickets.