Privacy Policy page should have suffix like other special pages

[danieltj]

The Privacy Policy page (when set in the Privacy page within Tools > Privacy) doesn't have the special page suffix like the Home and Blog pages do. As this page has special options when officially set as The Privacy Policy Page, it needs to have a suffix so people can pick it out easily from the list of pages.

[danieltj]

Privacy Policy page without the special page suffix

[subrataemfluence]

src/wp-admin/includes/template.php

[subrataemfluence]

Suffix modified from 'Privacy Policy' to 'Privacy Page'.

[desrosj]

Moving to the new Privacy component.

[ocean90]

#44132 was marked as a duplicate.

[desrosj]

This is a great idea.

44006.2.diff​ has a few minor improvements:

• Remove the first conditional, it was superfluous because the second condition would always catch the first too.
• Added some missing spaces to ​adhere to the coding standards.
• Changed the text to Privacy Policy Page for consistency with the option name.

[ianbelanger]

Tested 44006.2.diff and the patch applies cleanly and works as intended. Screenshot coming.

[ianbelanger]

Privacy Policy page suffix

[desrosj]

As discussed in today's ​Privacy component bug scrub, the text seems a bit repetitive when the page's name is "Privacy Policy". But not sure that there is anything we can do about this. The page title is not guaranteed to be "Privacy Policy" (a user could change it any time they want).

[ianbelanger]

Just tested the latest patch and the Privacy Policy link is removed when there is no title for the Privacy Policy page.

Nice work @desrosj

[ocean90]

4.9.7 has been released, moving to next milestone.

[pbiron]

Is this ready to land in 4.9.8?

The general feeling during today's bug scrub is that it is ready, but just want to confirm. If so, will the patch need a @since 4.9.8 refresh?

[desrosj]

This is good to go. My only remaining question is the casing of "page". See the discussion on 44130#comment:7.

[pbiron]

Replying to desrosj:

This is good to go. My only remaining question is the casing of "page". See the discussion on 44130#comment:7.

I don't have strong feelings one way or the other about 44130#comment:7, but for consistency with the Front Page and Posts Page post_states, I'd prefer Privacy Policy Page for this one.

[desrosj]

I agree, @pbiron. Marking this as commit.

[SergeyBiryukov]

In 43495:

Privacy: Mark Privacy Policy page as such in the Pages list table.

Props desrosj, subrataemfluence, ianbelanger, danieltj.
Fixes #44006.

[SergeyBiryukov]

In 43496:

Privacy: Mark Privacy Policy page as such in the Pages list table.

Props desrosj, subrataemfluence, ianbelanger, danieltj.
Merges [43495] to the 4.9 branch.
Fixes #44006.