Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#44006 closed enhancement (fixed)

Privacy Policy page should have suffix like other special pages

Reported by: danieltj's profile danieltj Owned by: desrosj's profile desrosj
Milestone: 4.9.8 Priority: normal
Severity: minor Version: 4.9.6
Component: Privacy Keywords: has-screenshots has-patch commit
Focuses: administration Cc:

Description

The Privacy Policy page (when set in the Privacy page within Tools > Privacy) doesn't have the special page suffix like the Home and Blog pages do. As this page has special options when officially set as The Privacy Policy Page, it needs to have a suffix so people can pick it out easily from the list of pages.

Attachments (6)

privacy-policy.png (78.8 KB) - added by danieltj 6 years ago.
Privacy Policy page without the special page suffix
44006.diff (632 bytes) - added by subrataemfluence 6 years ago.
src/wp-admin/includes/template.php
privacy-polity-with-suffix.png (5.1 KB) - added by subrataemfluence 6 years ago.
44006-2.diff (630 bytes) - added by subrataemfluence 6 years ago.
Suffix modified from 'Privacy Policy' to 'Privacy Page'.
44006.2.diff (570 bytes) - added by desrosj 6 years ago.
44006-privacy-policy-page-label.PNG (5.2 KB) - added by ianbelanger 6 years ago.
Privacy Policy page suffix

Download all attachments as: .zip

Change History (27)

@danieltj
6 years ago

Privacy Policy page without the special page suffix

#1 @danieltj
6 years ago

  • Keywords has-screenshots gdpr added

@subrataemfluence
6 years ago

src/wp-admin/includes/template.php

#2 @subrataemfluence
6 years ago

  • Keywords has-patch added; needs-patch removed

@subrataemfluence
6 years ago

Suffix modified from 'Privacy Policy' to 'Privacy Page'.

This ticket was mentioned in Slack in #gdpr-compliance by allendav. View the logs.


6 years ago

#4 @desrosj
6 years ago

  • Component changed from Posts, Post Types to Privacy

Moving to the new Privacy component.

#5 @ocean90
6 years ago

#44132 was marked as a duplicate.

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


6 years ago

#7 @desrosj
6 years ago

  • Owner set to desrosj
  • Status changed from new to reviewing

@desrosj
6 years ago

#8 @desrosj
6 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 4.9.7
  • Version changed from trunk to 4.9.6

This is a great idea.

44006.2.diff has a few minor improvements:

  • Remove the first conditional, it was superfluous because the second condition would always catch the first too.
  • Added some missing spaces to adhere to the coding standards.
  • Changed the text to Privacy Policy Page for consistency with the option name.

#9 @ianbelanger
6 years ago

  • Keywords needs-testing removed

Tested 44006.2.diff and the patch applies cleanly and works as intended. Screenshot coming.

@ianbelanger
6 years ago

Privacy Policy page suffix

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


6 years ago

#11 @desrosj
6 years ago

As discussed in today's Privacy component bug scrub, the text seems a bit repetitive when the page's name is "Privacy Policy". But not sure that there is anything we can do about this. The page title is not guaranteed to be "Privacy Policy" (a user could change it any time they want).

#12 @ianbelanger
6 years ago

Version 1, edited 6 years ago by ianbelanger (previous) (next) (diff)

#13 @ocean90
6 years ago

  • Milestone changed from 4.9.7 to 4.9.8

4.9.7 has been released, moving to next milestone.

This ticket was mentioned in Slack in #core by pbiron. View the logs.


6 years ago

#15 @pbiron
6 years ago

Is this ready to land in 4.9.8?

The general feeling during today's bug scrub is that it is ready, but just want to confirm. If so, will the patch need a @since 4.9.8 refresh?

#16 follow-up: @desrosj
6 years ago

This is good to go. My only remaining question is the casing of "page". See the discussion on 44130#comment:7.

#17 in reply to: ↑ 16 @pbiron
6 years ago

Replying to desrosj:

This is good to go. My only remaining question is the casing of "page". See the discussion on 44130#comment:7.

I don't have strong feelings one way or the other about 44130#comment:7, but for consistency with the Front Page and Posts Page post_states, I'd prefer Privacy Policy Page for this one.

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


6 years ago

#19 @desrosj
6 years ago

  • Keywords commit added; gdpr removed

I agree, @pbiron. Marking this as commit.

#20 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 43495:

Privacy: Mark Privacy Policy page as such in the Pages list table.

Props desrosj, subrataemfluence, ianbelanger, danieltj.
Fixes #44006.

#21 @SergeyBiryukov
6 years ago

In 43496:

Privacy: Mark Privacy Policy page as such in the Pages list table.

Props desrosj, subrataemfluence, ianbelanger, danieltj.
Merges [43495] to the 4.9 branch.
Fixes #44006.

Note: See TracTickets for help on using tickets.