Use wp_delete_file() instead of unlink() when generating a privacy data export file

[desrosj]

In #43905, the suggestion was made to use wp_delete_file() instead of unlink() when preparing a privacy data export file. This is a good suggestion, but it was made too late in the 4.9.6 process.

Creating this ticket to keep track of this suggestion for 4.9.7.

[iandunn]

Thanks for creating this to help keep track :)

IIRC, there are a few other instances of unlink() in the 4.9.6 commits. @macbookandrew found another in https://core.trac.wordpress.org/attachment/ticket/43546/43546.patch. I think it'd be good to find them all and update them all at once.

[macbookandrew]

I created a ticket and patch for the rest of the codebase: https://core.trac.wordpress.org/ticket/43990

[iandunn]

Duplicate of #43990.

Ah, nice. Thanks!

[desrosj]

Moving to the new Privacy component.