WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4403 closed defect (bug) (fixed)

Tags duplicated when editing comments

Reported by: ryan Owned by:
Milestone: 2.2.1 Priority: normal
Severity: normal Version: 2.2.1
Component: Administration Keywords:
Focuses: Cc:

Description

Create a comment with the text "test".

Edit the comment, you will see this in the textarea.

<p>test</p>

Click "Edit Comment" to save the comment. Don't make any changes.

Edit it again. The textarea now has this:

<p><p>test</p></p>

Save and edit a third time and you get:

<p><p></p><p>test</p></p>

Change History (8)

comment:1 ryan7 years ago

  • Summary changed from autop duplicates tags when editing comments to Tags duplicated when editing comments

I think this is fallout from #4333. Working on a fix.

comment:2 ryan7 years ago

Running the comment_text filter before calling format_to_edit in get_comment_to_edit() fixes it. Calling the comment_text filter when editing a comment is odd. We typically use such filters only when displaying the text on the front page, not when editing. However, we've been running comment_text on comments while editing for awhile now, so I'll leave it.

comment:3 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5646]) Run comment_text filter before format_to_edit() when getting a comment to edit. fixes #4403 for 2.3

comment:4 ryan7 years ago

(In [5647]) Run comment_text filter before format_to_edit() when getting a comment to edit. fixes #4403 for 2.2

comment:5 ryan7 years ago

(In [5648]) Run comment_text filter before format_to_edit() when getting a comment to edit. fixes #4403 for 2.0

comment:6 ryan7 years ago

(In [5655]) Remove comment_text filter from get_comment_to_edit. fixes #4403 for 2.3

comment:7 ryan7 years ago

(In [5656]) Remove comment_text filter from get_comment_to_edit. fixes #4403 for 2.2

comment:8 ryan7 years ago

(In [5657]) Remove comment_text filter from get_comment_to_edit. fixes #4403 for 2.0

Note: See TracTickets for help on using tickets.