WordPress.org

Make WordPress Core

Opened 6 weeks ago

Closed 4 days ago

Last modified 4 days ago

#44030 closed enhancement (fixed)

Remove unnecessary `This email has been sent to ###EMAIL###` from privacy emails.

Reported by: iandunn Owned by: ianbelanger
Milestone: 4.9.7 Priority: low
Severity: normal Version: 4.9.6
Component: Privacy Keywords: gdpr good-first-bug has-patch commit
Focuses: Cc:

Description

Several privacy related emails contain a string in the body saying, This email has been sent to ###EMAIL###. It appears that this was copied from the emails that get sent when an email address changes, without considering if it made sense in the new context.

I think that string is appropriate in the original use cases, because explicitly calling out the receiving address can help avoid confusion, since the address is changing.

The string is not used in any other emails in Core, though, except for some of the new privacy ones from 4.9.6. I think the string is unnecessary in the new context, and it's best to remove it.

The recipient address is already obvious enough from the To header, and removing unnecessary content will make the messages shorter, and maybe even avoid some suspicion from spam filters, which sometimes penalize seemingly innocent text, especially if it contains URLs or email addresses.

Attachments (2)

44030.diff (732 bytes) - added by ianbelanger 6 weeks ago.
Removed 2 instances of the unnecessary email text
44030.2.diff (2.2 KB) - added by desrosj 3 weeks ago.

Download all attachments as: .zip

Change History (11)

#1 @desrosj
6 weeks ago

  • Keywords good-first-bug added
  • Milestone changed from Awaiting Review to 4.9.7

@ianbelanger
6 weeks ago

Removed 2 instances of the unnecessary email text

#2 @ianbelanger
6 weeks ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in Slack in #core by desrosj. View the logs.


5 weeks ago

#4 @desrosj
5 weeks ago

  • Milestone changed from 4.9.7 to Future Release

Moving gdpr tickets that are not bugs to Future Release until the next steps can be properly evaluated.

#5 @desrosj
5 weeks ago

  • Component changed from Mail to Privacy

Moving to the new Privacy component.

#6 @ianbelanger
3 weeks ago

  • Keywords needs-testing added

#7 @desrosj
3 weeks ago

  • Keywords commit added; needs-testing removed
  • Milestone changed from Future Release to 4.9.7
  • Owner set to ianbelanger
  • Status changed from new to assigned
  • Version changed from trunk to 4.9.6

Assigning to mark good first bug as claimed.

This tested well for me. I am uploading one small change. Because the user's email is removed from the text of the email, the note explaining the ###EMAIL### placeholder can be removed from the translation context and the inline documentation for the filters on that content.

@desrosj
3 weeks ago

#8 @SergeyBiryukov
4 days ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43353:

Privacy: Remove unnecessary This email has been sent to ###EMAIL### from privacy emails.

The line was copied from the emails that get sent when an email address changes, without considering if it made sense in the new context.

Props iandunn, ianbelanger, desrosj.
Fixes #44030.

#9 @SergeyBiryukov
4 days ago

In 43354:

Privacy: Remove unnecessary This email has been sent to ###EMAIL### from privacy emails.

The line was copied from the emails that get sent when an email address changes, without considering if it made sense in the new context.

Props iandunn, ianbelanger, desrosj.
Merges [43353] to the 4.9 branch.
Fixes #44030.

Note: See TracTickets for help on using tickets.