WordPress.org

Make WordPress Core

Opened 6 weeks ago

Last modified 5 weeks ago

#44037 new defect (bug)

Cannot hide plugin description on responsive view

Reported by: subrataemfluence Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: trunk
Component: Administration Keywords: needs-patch
Focuses: ui, administration Cc:

Description

Plugin description is not toggling by clicking Screen Options > Description on responsive view.

Steps for reproduction:

  1. Go to Plugin page
  2. Enter responsive view (Chrome: Shift+Ctrl+I, FireFox: Shift+Ctrl+M)
  3. Pull down Screen Options dialog by clicking on Screen Options button at top right corner
  4. Check / Uncheck Description checkbox
  5. Description visibility never toggles.

In both desktop and responsive views the markup stays the same:

<div class='plugin-description'><p>Plugin description here...</p></div>

Tested in Chrome and FireFox
OS: Ubuntu 14.04
WordPress version: 5.0-alpha-43205

Screenshot attached.

Attachments (1)

description-not-disappearing.png (17.6 KB) - added by subrataemfluence 6 weeks ago.

Download all attachments as: .zip

Change History (3)

#1 @guldoe
6 weeks ago

Good catch.

Yes, there is a conflict in styles when is mobile or tablet.

hidden css style that add a display:none is not working because we have a display:block in the response mode in the td to make full width.

#2 @subrataemfluence
5 weeks ago

  • Version set to trunk

File /wp-admin/js/common.js

checked : function(column) {
   $('.column-' + column).removeClass( 'hidden' );
   if( $('.column-' + column).children().length > 0 ) {
      $('.column-' + column).children().removeClass( 'hidden' );
   }
   this.colSpanChange(+1);
},
 
unchecked : function(column) {
   $('.column-' + column).addClass( 'hidden' );
   if( $('.column-' + column).children().length > 0 ) {
      $('.column-' + column).children().addClass( 'hidden' );
   }
   this.colSpanChange(-1);
 },

If I add $('.column-' + column).find('div')... things work client side in both desktop and responsive views. But the problem is present column visibility state is not retained!

Note: See TracTickets for help on using tickets.