WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #44038, comment 12


Ignore:
Timestamp:
08/09/2018 09:26:41 PM (12 months ago)
Author:
desrosj
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #44038, comment 12

    initial v1  
    1 Thanks for the patch, @mrTall! [attachment:"44038.patch"] stores the relative patch for new exports, but it has one issue, and there are some additional scenarios that should be considered.
     1Thanks for the patch, @mrTall! [attachment:"44038.patch"] stores the relative patch for new exports, but it has one issue, and there are some additional scenarios that should be considered for backwards compatibility.
    22
    33[attachment:"44038.patch"] assumes the value stored in meta is always relative and adds the `$exports_dir` to the beginning of the value without examining it. Say a site has an old export (created before this change) that includes the full path in the meta value (`/srv/www/wordpress/public_html/wp-content/exports/exportfile.zip`, for example). The patch will always add the path to the beginning, even if it is the same, becoming `/srv/www/wordpress/public_html/wp-content/exports/srv/www/wordpress/public_html/wp-content/exports/exportfile.zip`.