WordPress.org

Make WordPress Core

Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#44063 closed defect (bug) (fixed)

Privacy policy guide: do not remove the "Suggested text has changed" bubble on saving the policy page

Reported by: azaozz Owned by: azaozz
Milestone: 4.9.6 Priority: normal
Severity: normal Version: 5.1
Component: Privacy Keywords: gdpr has-patch fixed-major dev-reviewed
Focuses: Cc:

Description

We went through several iterations before arriving at using mostly "the bubble" and not showing notices/warnings when the suggested text for privacy policy has changed. That made it harder to figure out what's expected and what's updated.

Seems we should be removing the bubble only when the Privacy Policy Guide screen gets loaded, and stop removing it when the privacy policy page gets saved/updated. This seems more logical: the bubble indicates that the guide has some new or updated content and the admin/site owner has to see it to remove the bubble.

Attachments (1)

44063.patch (516 bytes) - added by azaozz 15 months ago.

Download all attachments as: .zip

Change History (11)

@azaozz
15 months ago

#1 @azaozz
15 months ago

In 44063.patch: do not remove the "suggested text has changed" bubble unless the user visits the policy guide.

#2 @ocean90
15 months ago

In 43261:

Privacy: Remove is-dismissible class from notice when privacy info has changed.

The notice isn't dismissible as it only gets removed once you visit the privacy guide, see #44057 and #44063.

Fixes #44065.

#3 @ocean90
15 months ago

In 43262:

Privacy: Remove is-dismissible class from notice when privacy info has changed.

The notice isn't dismissible as it only gets removed once you visit the privacy guide, see #44057 and #44063.

Merge of [43260] to the 4.9 branch.

See #44065.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


15 months ago

#5 @azaozz
15 months ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 43269:

Privacy: only remove the "Suggested text has changed" bubble when an admin visits the Privacy Policy Guide screen.

Fixes #44063.

#6 @azaozz
15 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 4.9.6.

#7 @iandunn
15 months ago

  • Keywords dev-feedback added

#8 @SergeyBiryukov
15 months ago

  • Keywords dev-reviewed added; dev-feedback removed

#9 @SergeyBiryukov
15 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43273:

Privacy: only remove the "Suggested text has changed" bubble when an admin visits the Privacy Policy Guide screen.

Props azaozz.
Merges [43269] to the 4.9 branch.
Fixes #44063.

#10 @desrosj
15 months ago

  • Component changed from General to Privacy

Moving to the new Privacy component.

Note: See TracTickets for help on using tickets.