Unreachable condition in elseIF

[akshayar]

There is duplicate 'is_post_type_archive' conditional check-in 'elseif' condition. You can check 'feed_links_extra()' function located at 'general-template.php' file under 'wp-includes' directory conatains,

​https://github.com/WordPress/WordPress/blob/e76593098293fd1e87d666bd3acf339b46fd5110/wp-includes/general-template.php#L2799

This block will never get executed.

[swissspidy]

The first elseif is here: ​https://github.com/WordPress/WordPress/blob/e76593098293fd1e87d666bd3acf339b46fd5110/wp-includes/general-template.php#L2763

[akshayar]

Both blocks of code have a difference in fetching '$post_type_obj' and in generating the title. We can add an extra check to validate 'post_type_obj' and the attached ('feed-link-modified.patch') patch can be used.
As feed link for the archive is working, not changed reference in the earlier block.

[desrosj]

Thanks for the ticket and patches, @akshayar. #43860 has more discussion, so closing this ticket out as a duplicate.