WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 6 years ago

Last modified 6 years ago

#44088 closed enhancement (wontfix)

Merged two if into single in get_the_term_list()

Reported by: rnaby Owned by:
Priority: normal Milestone:
Component: Taxonomy Version:
Severity: normal Keywords: has-patch needs-testing
Cc: Focuses: template

Description

In get_the_term_list function there is no need to check with two if conditions. As at line 1246 of the same file inside get_the_terms function it is returning false when the $terms is empty then there is no need to check it again in get_the_term_list I think.

Attachments (1)

44088.diff​ (591 bytes ) - added by rnaby 8 years ago.
The patch for the ticket.

Download all attachments as: .zip

Change History (4)

@rnaby
8 years ago

The patch for the ticket.

#1 @pento
8 years ago

  • Version trunk

#2 @SergeyBiryukov
6 years ago

  • Milestone Awaiting Review
  • Resolution → wontfix
  • Status new → closed

Hi there, thanks for the patch! Sorry it took so long for someone to get back to it.

The existing code looks a bit clearer to me.

#3 @SergeyBiryukov
6 years ago

  • Summary Merged two if into single → Merged two if into single in get_the_term_list()
Note: See TracTickets for help on using tickets.