Make WordPress Core

Opened 6 years ago

Last modified 4 years ago

#44090 reviewing enhancement

Reword plugin compatibility text to something more meaningful

Reported by: danieltj's profile danieltj Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Future Release Priority: normal
Severity: minor Version:
Component: Plugins Keywords: has-screenshots has-patch needs-copy-review
Focuses: administration, ui-copy Cc:

Description

Currently, when looking at the plugins update table on the /wp-admin/update-core.php page, it says whether the plugin is compatible with the version of WordPress you are running and the latest version (or just the latest if you're on it).

It states that it's 100% compatible. This seems to be left over from the old days when people could rate if a plugin worked on a certain version, but this doesn't apply anymore as it either does work, or it doesn't. You can't quantify it with a percentage because it's just not possible. It either works or doesn't.

I'd suggest the wording here is updated to reflect the current state of plugin compatibility by replacing the percentage with either a yes or no value.

It's my understanding that based on the meta data in the plugin readme, it'll either be 0% or 100%, so that's either a 0 (no) or 1 (yes). I've attached a screenshot of what I mean.

Attachments (4)

plugin-update-table.png (80.0 KB) - added by danieltj 6 years ago.
Screenshot from 2018-05-15 20_31_35.png (19.2 KB) - added by subrataemfluence 6 years ago.
Percentage replaced with word "Compatible"
44090.diff (1.4 KB) - added by subrataemfluence 6 years ago.
Proposed patch
44090-refreshed.diff (1.5 KB) - added by subrataemfluence 4 years ago.
Refreshed

Download all attachments as: .zip

Change History (12)

#1 @subrataemfluence
6 years ago

  • Keywords has-screenshots added

You are right. I think 100% could be misleading at some situations. Rather it could be like Compatible OR Unknown based on Plugin compatibility for running or updated version of WordPress.

@subrataemfluence
6 years ago

Percentage replaced with word "Compatible"

@subrataemfluence
6 years ago

Proposed patch

#2 @subrataemfluence
6 years ago

  • Keywords has-patch added; needs-patch removed

#3 follow-up: @danieltj
5 years ago

  • Keywords needs-refresh added
  • Severity changed from normal to minor

That patch seems to have gotten the text strings the wrong way around. This ticket needs a bit of a refresh too as it's quite old. Perhaps something to consider for the 5.3 release maybe?

#4 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.6
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 in reply to: ↑ 3 @subrataemfluence
4 years ago

I completely missed this! Silly mistake. IT was indeed completely wrong way around as you had mentioned. I have uploaded a refreshed patch. Thank you for pointing out sir!

Replying to danieltj:

That patch seems to have gotten the text strings the wrong way around. This ticket needs a bit of a refresh too as it's quite old. Perhaps something to consider for the 5.3 release maybe?

Last edited 4 years ago by subrataemfluence (previous) (diff)

@subrataemfluence
4 years ago

Refreshed

This ticket was mentioned in PR #562 on WordPress/wordpress-develop by dream-encode.


4 years ago
#6

  • Keywords needs-refresh removed

Remove percentage based number from compatibility of the updates in favor of "compatible."

Trac ticket: https://core.trac.wordpress.org/ticket/44090

#7 @garrett-eclipse
4 years ago

  • Focuses ui-copy added
  • Keywords needs-copy-review added

Reviewing the patch if feels a bit weird to say 'Compatibility' and 'Compatible' in the same line. I wonder if we can improve the language here.

From the code it appears we have the following strings for both the current and latest version of WordPress;
'Compatibility with WordPress %s: 100%% (according to its author)'
'Compatibility with WordPress %s: Unknown'

  • I assume this was repeated for the latest version of WP to avoid additional strings.

IMO we can humanized the strings and have four descriptive ones;
'According to the author this plugin is compatible with the currently installed version of WordPress (%s).
'It's unknown if this plugin is compatible with the currently installed version of WordPress (%s).
'According to the author this plugin is compatible with the latest available version of WordPress (%s).
'It's unknown if this plugin is compatible with the latest available version of WordPress (%s).
*Adding copy review to get feedback.

Also, with the existing patch the % after Compatible should be removed it was there to escape the % sign in 100% and since the escaping isn't needed that can be removed.

#8 @SergeyBiryukov
4 years ago

  • Milestone changed from 5.6 to Future Release

Looks like this needs some more work. With 5.6 Beta 1 landing today, moving to Future Release.

Note: See TracTickets for help on using tickets.