WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#44093 closed enhancement (fixed)

Proposed Adjustment to Privacy Settings buttons

Reported by: ianbelanger's profile ianbelanger Owned by: azaozz's profile azaozz
Milestone: 4.9.6 Priority: normal
Severity: normal Version: 5.1
Component: Privacy Keywords: gdpr has-patch fixed-major commit
Focuses: ui Cc:

Description

I am proposing that we align the Create New Page button below Or: in the responsive view, under 782px. Screenshots and patch coming.

Attachments (5)

44093-privacy-settings-button-before-patch.PNG​ (36.5 KB) - added by ianbelanger 6 years ago.
Original view
44093-privacy-settings-button-after-patch.PNG​ (39.5 KB) - added by ianbelanger 6 years ago.
After proposed changes
44093.diff​ (553 bytes) - added by ianbelanger 6 years ago.
Add responsive CSS to move Create New Page button below Or:
44093-privacy-settings-button-updated-margins.PNG​ (17.1 KB) - added by ianbelanger 6 years ago.
Screenshot for most recent patch 44093.2
44093.2.diff​ (1.2 KB) - added by ianbelanger 6 years ago.
Added "cpp-wide" class to span for more targeted approach and vertically centered Or: between buttons

Download all attachments as: .zip

Change History (18)

@ianbelanger
6 years ago

Original view

@ianbelanger
6 years ago

After proposed changes

@ianbelanger
6 years ago

Add responsive CSS to move Create New Page button below Or:

#1 @desrosj
6 years ago

I like that batter. I think that eventually, this page should utilize the settings API.

I think the margin should be equal on the top and bottom of the or, though.

This ticket was mentioned in ​Slack in #gdpr-compliance by desrosj. ​View the logs.
6 years ago

#3 @allendav
6 years ago

I have no strong feelings either way.

@ianbelanger
6 years ago

Screenshot for most recent patch 44093.2

@ianbelanger
6 years ago

Added "cpp-wide" class to span for more targeted approach and vertically centered Or: between buttons

#4 @iandunn
6 years ago

  • Focuses ui added
  • Keywords gdpr has-patch added
  • Status changed from new to assigned
  • Version set to trunk

@melchoyce ​approved the screenshots.

#5 @azaozz
6 years ago

Looking at 44093.2.diff still thinking that .tools-privacy-policy-page input.button is too generic. Fixing.

#6 @azaozz
6 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from assigned to closed

In 43279:

Privacy: fix styling of the Privacy Settings buttons on mobile/small screens.

Props ianbelanger, azaozz.
Fixes #44093.

#7 @azaozz
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 4.9.6.

#8 @azaozz
6 years ago

  • Keywords fixed-major added

#9 @azaozz
6 years ago

  • Milestone changed from Awaiting Review to 4.9.6

This ticket was mentioned in ​Slack in #gdpr-compliance by azaozz. ​View the logs.
6 years ago

#11 @melchoyce
6 years ago

  • Keywords commit added

Patch looks good to me.

#12 @azaozz
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43280:

Privacy: fix styling of the Privacy Settings buttons on mobile/small screens.

Props ianbelanger, azaozz.
Merges [43279] to the 4.9 branch.
Fixes #44093.

#13 @desrosj
6 years ago

  • Component changed from General to Privacy

Moving to the new Privacy component.

Note: See TracTickets for help on using tickets.