WordPress.org

Make WordPress Core

Opened 5 weeks ago

Last modified 18 hours ago

#44099 reopened defect (bug)

Add Request Type into Admin Email Subject for GDPR

Reported by: garrett-eclipse Owned by: azaozz
Milestone: 4.9.7 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-screenshots has-patch gdpr commit fixed-major
Focuses: administration Cc:

Description

Hello,

Similar to #43968 the Admin notifications don't provide an indication in the subject for what action was confirmed, see screenshot.

Thanks

Attachments (4)

Screen Shot 2018-05-15 at 3.28.34 PM.png (21.4 KB) - added by garrett-eclipse 5 weeks ago.
Admin email with no indication to the request type
44099.diff (1.2 KB) - added by birgire 5 weeks ago.
44099.2.diff (2.9 KB) - added by desrosj 3 weeks ago.
44099.3.diff (1.3 KB) - added by desrosj 32 hours ago.

Download all attachments as: .zip

Change History (17)

@garrett-eclipse
5 weeks ago

Admin email with no indication to the request type

#1 @birgire
5 weeks ago

  • Keywords has-screenshots has-patch gdpr added

44099.diff adds the name of the action to the subject of the confirmation email.

Example:

[Test Site] Action Confirmed: Export Personal Data

@birgire
5 weeks ago

#2 @desrosj
5 weeks ago

  • Component changed from General to Privacy

Moving to the new Privacy component.

#3 @desrosj
5 weeks ago

  • Version changed from trunk to 4.9.6

Marking Privacy change as introduced in 4.9.6.

#4 @desrosj
3 weeks ago

This looks good and is working for me!

I'd like to also add a filter to the subject in this email for parity while we are at it. One already exists for the email sent to a user to confirm the action (user_request_action_email_subject), and I just created #44265 for the erasure complete email.

@desrosj
3 weeks ago

#5 @desrosj
3 weeks ago

  • Keywords needs-testing added

44099.2.diff adds a filter to the subject of the email and adds a missing parameter to the email content filter.

#6 @desrosj
3 weeks ago

  • Milestone changed from Awaiting Review to 4.9.7

#7 @desrosj
3 weeks ago

  • Keywords needs-unit-tests added; needs-testing removed

#8 @desrosj
3 weeks ago

The tests for this should be added to the test class being worked on in #43967.

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


35 hours ago

@desrosj
32 hours ago

#10 @desrosj
32 hours ago

  • Keywords commit added; needs-unit-tests removed

The missing subject filter was added in #44382. 44099.3.diff removes that change and focuses only on including the action that was confirmed in the email subject.

When this is committed, unit tests can be added in #43967. I will update that ticket with a reminder to include tests for this.

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


32 hours ago

#12 @azaozz
18 hours ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 43375:

Privacy: add user request type to the admin notification email subject.

Props birgire, desrosj.
Fixes #44099.

#13 @azaozz
18 hours ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 4.9.7.

Note: See TracTickets for help on using tickets.