Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#44099 closed defect (bug) (fixed)

Add Request Type into Admin Email Subject for GDPR

Reported by: garrett-eclipse Owned by: azaozz
Priority: normal Milestone: 4.9.8
Component: Privacy Version: 4.9.6
Severity: normal Keywords: has-screenshots has-patch gdpr commit fixed-major
Cc: Focuses: administration

Description

Hello,

Similar to #43968 the Admin notifications don't provide an indication in the subject for what action was confirmed, see screenshot.

Thanks

Attachments (4)

Screen Shot 2018-05-15 at 3.28.34 PM.png​ (21.4 KB ) - added by garrett-eclipse 8 years ago.
Admin email with no indication to the request type
44099.diff​ (1.2 KB ) - added by birgire 8 years ago.
44099.2.diff​ (2.9 KB ) - added by desrosj 8 years ago.
44099.3.diff​ (1.3 KB ) - added by desrosj 8 years ago.

Download all attachments as: .zip

Change History (20)

@garrett-eclipse
8 years ago

Admin email with no indication to the request type

#1 @birgire
8 years ago

  • Keywords has-screenshots has-patch gdpr added

44099.diff​ adds the name of the action to the subject of the confirmation email.

Example:

[Test Site] Action Confirmed: Export Personal Data

@birgire
8 years ago

#2 @desrosj
8 years ago

  • Component General → Privacy

Moving to the new Privacy component.

#3 @desrosj
8 years ago

  • Version trunk → 4.9.6

Marking Privacy change as introduced in 4.9.6.

#4 @desrosj
8 years ago

This looks good and is working for me!

I'd like to also add a filter to the subject in this email for parity while we are at it. One already exists for the email sent to a user to confirm the action (user_request_action_email_subject), and I just created #44265 for the erasure complete email.

@desrosj
8 years ago

#5 @desrosj
8 years ago

  • Keywords needs-testing added

44099.2.diff​ adds a filter to the subject of the email and adds a missing parameter to the email content filter.

#6 @desrosj
8 years ago

  • Milestone Awaiting Review → 4.9.7

#7 @desrosj
8 years ago

  • Keywords needs-unit-tests added; needs-testing removed

#8 @desrosj
8 years ago

The tests for this should be added to the test class being worked on in #43967.

This ticket was mentioned in ​Slack in #core-privacy by desrosj. ​View the logs.


8 years ago

@desrosj
8 years ago

#10 @desrosj
8 years ago

  • Keywords commit added; needs-unit-tests removed

The missing subject filter was added in #44382. 44099.3.diff​ removes that change and focuses only on including the action that was confirmed in the email subject.

When this is committed, unit tests can be added in #43967. I will update that ticket with a reminder to include tests for this.

This ticket was mentioned in ​Slack in #core-privacy by desrosj. ​View the logs.


8 years ago

#12 @azaozz
8 years ago

  • Owner set to azaozz
  • Resolution → fixed
  • Status new → closed

In 43375:

Privacy: add user request type to the admin notification email subject.

Props birgire, desrosj.
Fixes #44099.

#13 @azaozz
8 years ago

  • Keywords fixed-major added
  • Resolution fixed
  • Status closed → reopened

Reopen for 4.9.7.

#14 @ocean90
8 years ago

  • Milestone 4.9.7 → 4.9.8

4.9.7 has been released, moving to next milestone.

#15 @SergeyBiryukov
8 years ago

  • Resolution → fixed
  • Status reopened → closed

In 43450:

Privacy: add user request type to the admin notification email subject.

Merges [43375] to the 4.9 branch.
Props birgire, desrosj.
Fixes #44099.

#16 @SergeyBiryukov
8 years ago

Note: [43450] accidentally includes [43373], which needed a backport anyway. I guess it's fine to leave that as is.

Note: See TracTickets for help on using tickets.