Customize: Attempt to count uncountable value

[dlh]

WP_Customize_Nav_Menus::search_available_items_query() attempts to count an instance of WP_Customize_Setting, which generates a warning in PHP 7.2.

It looks to me like the intent was to count the value of the setting instead, which should be an array.

[desrosj]

Moving all tickets in 4.9.7 to 4.9.8.

[dlh]

It looks to me like this warning can be generated in the existing test for search_available_items_query() by ensuring that the nav_menus_created_posts setting has been added, which can be done by calling do_action( 'customize_register' ) at the beginning of the test. test_save_nav_menus_created_posts() uses a similar pattern. 44104.2.diff​ adds that line to the test.

[pento]

This is ready for commit and backport.

[azaozz]

In 43480:

Customize: Do not attempt to count uncountable value.

Props dlh.
Fixes #44104.

[azaozz]

Reopen for 4.9.8.

[azaozz]

In 43481:

Customize: Do not attempt to count uncountable value.

Props dlh.
Merges [43480] to the 4.9 branch.
Fixes #44104.