Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#44106 closed defect (bug) (worksforme)

Embed code not being regenerated on link change in Insert/edit media dialog

Reported by: brmoore252's profile brmoore252 Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9.5
Component: TinyMCE Keywords:
Focuses: Cc:


When using the Insert/edit media dialog to embed videos, if a user puts a source link in for an unrecognized URL, it will generate a <video> tag, if it is recognized (at least if it's youtube), it will generate an iframe. However, if the user changes the URL, for example puts an unrecognized link in then changes it to youtube, the youtube link then just gets placed in the src of the video tag instead of regenerating an iframe tag, and vice versa.

Change History (1)

#1 @azaozz
5 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

This is a bit confusing but think the behaviour is correct.

If the user intends to add a video from URL, but the inserted URL doesn't point to a playable video, or if the user edits a video URL, and the edited URL doesn't point to another video, the preview should show the error (i.e. this was supposed to be a video but is not). The same "missing video" box will be on the front-end when the post is published.

Closing as worksforme. Feel free to reopen with ideas for better behaviour or if I've missed something.

Note: See TracTickets for help on using tickets.