WordPress.org

Make WordPress Core

Opened 14 months ago

Closed 12 months ago

Last modified 12 months ago

#44109 closed defect (bug) (fixed)

TwentySeventeen backend editor: level 2 bulleted lists nested under numbered lists show numbers instead of bullets

Reported by: macbookandrew Owned by: SergeyBiryukov
Milestone: 4.9.8 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch commit
Focuses: Cc:

Description

In the backend editor when using the TwentySeventeen theme, level 2 bulleted lists nested under numbered lists show numbers instead of bullets, and subsequent numbers are incremented accordingly (and incorrectly).

Attachments (6)

Visual.png (47.1 KB) - added by macbookandrew 14 months ago.
Visual editor with incorrect numbering
Text.png (64.8 KB) - added by macbookandrew 14 months ago.
Text editor showing the markup
44109.patch (535 bytes) - added by macbookandrew 14 months ago.
Patch to fix the issue
Visual-fixed.png (45.6 KB) - added by macbookandrew 14 months ago.
Visual editor with fixed numbering/bulleting
Capture d’écran 2018-05-24 à 07.11.36.png (58.7 KB) - added by audrasjb 14 months ago.
sample structure in html mode
Capture d’écran 2018-05-24 à 07.11.19.png (42.9 KB) - added by audrasjb 14 months ago.
sample structure in visual mode

Download all attachments as: .zip

Change History (12)

@macbookandrew
14 months ago

Visual editor with incorrect numbering

@macbookandrew
14 months ago

Text editor showing the markup

@macbookandrew
14 months ago

Patch to fix the issue

@macbookandrew
14 months ago

Visual editor with fixed numbering/bulleting

This ticket was mentioned in Slack in #core-themes by macbookandrew. View the logs.


14 months ago

#2 @audrasjb
14 months ago

  • Milestone changed from Awaiting Review to 4.9.8

Hello and thanks for your ticket,

I tested your patch (some screenshots below) and I confirm 44109.patch applies cleanly on editor-style.
Did not found any issue or edge case.

Moving it to 4.9.8 since this is a real bug fix.

Cheers,
Jb

@audrasjb
14 months ago

sample structure in html mode

@audrasjb
14 months ago

sample structure in visual mode

#3 @desrosj
14 months ago

  • Keywords commit added
  • Milestone changed from 4.9.8 to 4.9.7

Patch works great for me. I also tested using the lists in reverse (an ol within an ul) and that also worked without issue.

#4 @ocean90
13 months ago

  • Milestone changed from 4.9.7 to 4.9.8

4.9.7 has been released, moving to next milestone.

#5 @SergeyBiryukov
12 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 43493:

Twenty Seventeen: Correct list item style for nested unordered lists.

Props macbookandrew, audrasjb.
Fixes #44109.

#6 @SergeyBiryukov
12 months ago

In 43494:

Twenty Seventeen: Correct list item style for nested unordered lists.

Props macbookandrew, audrasjb.
Merges [43493] to the 4.9 branch.
Fixes #44109.

Note: See TracTickets for help on using tickets.