WordPress.org

Make WordPress Core

Opened 6 weeks ago

Last modified 5 weeks ago

#44109 new defect (bug)

TwentySeventeen backend editor: level 2 bulleted lists nested under numbered lists show numbers instead of bullets

Reported by: macbookandrew Owned by:
Milestone: 4.9.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch commit
Focuses: Cc:

Description

In the backend editor when using the TwentySeventeen theme, level 2 bulleted lists nested under numbered lists show numbers instead of bullets, and subsequent numbers are incremented accordingly (and incorrectly).

Attachments (6)

Visual.png (47.1 KB) - added by macbookandrew 6 weeks ago.
Visual editor with incorrect numbering
Text.png (64.8 KB) - added by macbookandrew 6 weeks ago.
Text editor showing the markup
44109.patch (535 bytes) - added by macbookandrew 6 weeks ago.
Patch to fix the issue
Visual-fixed.png (45.6 KB) - added by macbookandrew 6 weeks ago.
Visual editor with fixed numbering/bulleting
Capture d’écran 2018-05-24 à 07.11.36.png (58.7 KB) - added by audrasjb 5 weeks ago.
sample structure in html mode
Capture d’écran 2018-05-24 à 07.11.19.png (42.9 KB) - added by audrasjb 5 weeks ago.
sample structure in visual mode

Download all attachments as: .zip

Change History (9)

@macbookandrew
6 weeks ago

Visual editor with incorrect numbering

@macbookandrew
6 weeks ago

Text editor showing the markup

@macbookandrew
6 weeks ago

Patch to fix the issue

@macbookandrew
6 weeks ago

Visual editor with fixed numbering/bulleting

This ticket was mentioned in Slack in #core-themes by macbookandrew. View the logs.


5 weeks ago

#2 @audrasjb
5 weeks ago

  • Milestone changed from Awaiting Review to 4.9.8

Hello and thanks for your ticket,

I tested your patch (some screenshots below) and I confirm 44109.patch applies cleanly on editor-style. Did not found any issue or edge case.

Moving it to 4.9.8 since this is a real bug fix.

Cheers, Jb

@audrasjb
5 weeks ago

sample structure in html mode

@audrasjb
5 weeks ago

sample structure in visual mode

#3 @desrosj
5 weeks ago

  • Keywords commit added
  • Milestone changed from 4.9.8 to 4.9.7

Patch works great for me. I also tested using the lists in reverse (an ol within an ul) and that also worked without issue.

Note: See TracTickets for help on using tickets.