![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 8 years ago
Closed 8 years ago
#44110 closed enhancement (invalid)
Removed unnecessary else's in admin.php
| Reported by: | rnaby | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Administration | Version: | 5.1 |
| Severity: | normal | Keywords: | has-patch needs-testing |
| Cc: | Focuses: | administration |
Description
As the global variables are getting declared in top, so I think the else conditions are unnecessary here.
Attachments (1)
Change History (2)
#1
@
8 years ago
- Component General → Administration
- Milestone Awaiting Review
- Resolution → invalid
- Status new → closed
Hi @rnaby, welcome to WordPress Trac!
The $typenow global is indeed declared a few lines above, but its value is undefined. The else condition makes sure the variable is always defined, so it cannot be removed.
Note:
See TracTickets
for help on using tickets.
Th patch for the ticket.